unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#19491: /etc/mtab give wrong entries for early-mounted items.
@ 2015-01-02 12:13 宋文武
  2015-01-03 18:57 ` Ludovic Courtès
  2015-01-08 13:11 ` bug#19491: Fixed 宋文武
  0 siblings, 2 replies; 5+ messages in thread
From: 宋文武 @ 2015-01-02 12:13 UTC (permalink / raw)
  To: 19491

Notably, I have:
  /dev/sda1 /root ext4 rw,relatime,data=ordered 0 0
  none /root//dev devtmpfs rw 0 0

Which should be:
  /dev/sda1 / ...
  none /dev ...

Why not make /etc/mtab a symlink to /proc/self/mounts?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#19491: /etc/mtab give wrong entries for early-mounted items.
  2015-01-02 12:13 bug#19491: /etc/mtab give wrong entries for early-mounted items 宋文武
@ 2015-01-03 18:57 ` Ludovic Courtès
  2015-01-04 12:50   ` 宋文武
  2015-01-08 13:11 ` bug#19491: Fixed 宋文武
  1 sibling, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2015-01-03 18:57 UTC (permalink / raw)
  To: 宋文武; +Cc: 19491

宋文武 <iyzsong@gmail.com> skribis:

> Notably, I have:
>   /dev/sda1 /root ext4 rw,relatime,data=ordered 0 0
>   none /root//dev devtmpfs rw 0 0
>
> Which should be:
>   /dev/sda1 / ...
>   none /dev ...
>
> Why not make /etc/mtab a symlink to /proc/self/mounts?

This sounds appealing, but it seems that libmount in util-linux will
insist to update /etc/mtab.

Do you have evidence that it could cope with it?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#19491: /etc/mtab give wrong entries for early-mounted items.
  2015-01-03 18:57 ` Ludovic Courtès
@ 2015-01-04 12:50   ` 宋文武
  2015-01-04 16:04     ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: 宋文武 @ 2015-01-04 12:50 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 19491

Ludovic Courtès <ludo@gnu.org> writes:

> 宋文武 <iyzsong@gmail.com> skribis:
>
>> Notably, I have:
>>   /dev/sda1 /root ext4 rw,relatime,data=ordered 0 0
>>   none /root//dev devtmpfs rw 0 0
>>
>> Which should be:
>>   /dev/sda1 / ...
>>   none /dev ...
>>
>> Why not make /etc/mtab a symlink to /proc/self/mounts?
>
> This sounds appealing, but it seems that libmount in util-linux will
> insist to update /etc/mtab.
>
> Do you have evidence that it could cope with it?
Not sure, but I think libmount should just work fine.

util-linux support this since 2.19:
  https://www.kernel.org/pub/linux/utils/util-linux/v2.19/v2.19-ReleaseNotes

Debian make this default at 2011:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=494001
>
> Thanks,
> Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#19491: /etc/mtab give wrong entries for early-mounted items.
  2015-01-04 12:50   ` 宋文武
@ 2015-01-04 16:04     ` Ludovic Courtès
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2015-01-04 16:04 UTC (permalink / raw)
  To: 宋文武; +Cc: 19491

宋文武 <iyzsong@gmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> 宋文武 <iyzsong@gmail.com> skribis:
>>
>>> Notably, I have:
>>>   /dev/sda1 /root ext4 rw,relatime,data=ordered 0 0
>>>   none /root//dev devtmpfs rw 0 0
>>>
>>> Which should be:
>>>   /dev/sda1 / ...
>>>   none /dev ...
>>>
>>> Why not make /etc/mtab a symlink to /proc/self/mounts?
>>
>> This sounds appealing, but it seems that libmount in util-linux will
>> insist to update /etc/mtab.
>>
>> Do you have evidence that it could cope with it?
> Not sure, but I think libmount should just work fine.
>
> util-linux support this since 2.19:
>   https://www.kernel.org/pub/linux/utils/util-linux/v2.19/v2.19-ReleaseNotes
>
> Debian make this default at 2011:
>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=494001

OK, it sounds like it’s safe, then.  :-)

Would you like to propose a patch?  There are changes to make around
linux-boot.scm, and also in (guix build syscalls) the #:update-mtab?
argument should default to #f.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#19491: Fixed
  2015-01-02 12:13 bug#19491: /etc/mtab give wrong entries for early-mounted items 宋文武
  2015-01-03 18:57 ` Ludovic Courtès
@ 2015-01-08 13:11 ` 宋文武
  1 sibling, 0 replies; 5+ messages in thread
From: 宋文武 @ 2015-01-08 13:11 UTC (permalink / raw)
  To: 19491-done

Fixed in commit 9331ba5d
by make /etc/mtab a symlink to /proc/self/mounts.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-01-08 13:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-02 12:13 bug#19491: /etc/mtab give wrong entries for early-mounted items 宋文武
2015-01-03 18:57 ` Ludovic Courtès
2015-01-04 12:50   ` 宋文武
2015-01-04 16:04     ` Ludovic Courtès
2015-01-08 13:11 ` bug#19491: Fixed 宋文武

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).