From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 35783@debbugs.gnu.org
Subject: bug#35783: Guile-Parted crashes the installer on i686-linux
Date: Sat, 18 May 2019 13:50:33 +0200 [thread overview]
Message-ID: <87imu8vv5i.fsf@gnu.org> (raw)
In-Reply-To: <87ftpchxel.fsf@gmail.com> (Mathieu Othacehe's message of "Sat, 18 May 2019 12:25:38 +0200")
Hi Mathieu,
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
> With this almost indentical patch, disk partitioning seems fine with and
> without existing esp partition on x64. I'll try to run more tests.
I was fiddling with this and had arrived to a similar patch, we’re in
perfect symbiosis. :-)
I’ve done some testing both in an EFI and a non-EFI setup with QEMU, and
it seems to work well; I’ll do some more testing as well.
>From 1e0734c4829725cdee6cab3cb05332ffd2a36a57 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe@gmail.com>
> Date: Sat, 18 May 2019 11:25:09 +0200
> Subject: [PATCH] draft: Fix esp user-partition creation.
[...]
> --- a/gnu/installer/parted.scm
> +++ b/gnu/installer/parted.scm
> @@ -1001,10 +1001,14 @@ swap partition, a root partition and a home partition."
> (mount-point "/home")))))))
> (new-partitions* (force-user-partitions-formatting
> new-partitions)))
> - (create-adjacent-partitions! disk
> - new-partitions*
> - #:last-partition-end
> - (or end-esp-partition 0)))))
> + (append
> + (if esp-partition
> + (list (partition->user-partition esp-partition))
> + '())
> + (create-adjacent-partitions! disk
> + new-partitions*
> + #:last-partition-end
> + (or end-esp-partition 0))))))
Perhaps add something like this to the docstring of ‘auto-partition!’:
Return the complete list of partitions on DISK, including the ESP when it
exists.
Longer-term it would be good to audit Guile-Parted: it probably
shouldn’t be possible for Guile-Parted to refer to “defunct” Parted
objects.
Thank you for the quick response!
Ludo’.
next prev parent reply other threads:[~2019-05-18 11:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 19:46 bug#35783: Guile-Parted crashes the installer on i686-linux Ludovic Courtès
2019-05-17 20:03 ` Jonathan Brielmaier
2019-05-17 21:22 ` Ludovic Courtès
2019-05-18 9:30 ` Mathieu Othacehe
2019-05-18 10:25 ` Mathieu Othacehe
2019-05-18 11:50 ` Ludovic Courtès [this message]
2019-05-19 14:24 ` Mathieu Othacehe
2019-05-20 8:17 ` Ludovic Courtès
2019-05-18 13:44 ` Ludovic Courtès
2019-05-19 10:09 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imu8vv5i.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35783@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).