From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: bug#35783: Guile-Parted crashes the installer on i686-linux Date: Sat, 18 May 2019 13:50:33 +0200 Message-ID: <87imu8vv5i.fsf@gnu.org> References: <87h89syidd.fsf@gnu.org> <877eaoydw8.fsf@gnu.org> <87h89shzyq.fsf@gmail.com> <87ftpchxel.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:60126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRxrk-0005LX-Sc for bug-guix@gnu.org; Sat, 18 May 2019 07:51:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRxrj-0008MF-SF for bug-guix@gnu.org; Sat, 18 May 2019 07:51:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRxrj-0008M8-Os for bug-guix@gnu.org; Sat, 18 May 2019 07:51:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hRxri-0003rW-30 for bug-guix@gnu.org; Sat, 18 May 2019 07:51:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87ftpchxel.fsf@gmail.com> (Mathieu Othacehe's message of "Sat, 18 May 2019 12:25:38 +0200") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Mathieu Othacehe Cc: 35783@debbugs.gnu.org Hi Mathieu, Mathieu Othacehe skribis: > With this almost indentical patch, disk partitioning seems fine with and > without existing esp partition on x64. I'll try to run more tests. I was fiddling with this and had arrived to a similar patch, we=E2=80=99re = in perfect symbiosis. :-) I=E2=80=99ve done some testing both in an EFI and a non-EFI setup with QEMU= , and it seems to work well; I=E2=80=99ll do some more testing as well. >>From 1e0734c4829725cdee6cab3cb05332ffd2a36a57 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Sat, 18 May 2019 11:25:09 +0200 > Subject: [PATCH] draft: Fix esp user-partition creation. [...] > --- a/gnu/installer/parted.scm > +++ b/gnu/installer/parted.scm > @@ -1001,10 +1001,14 @@ swap partition, a root partition and a home parti= tion." > (mount-point "/home"))))))) > (new-partitions* (force-user-partitions-formatting > new-partitions))) > - (create-adjacent-partitions! disk > - new-partitions* > - #:last-partition-end > - (or end-esp-partition 0))))) > + (append > + (if esp-partition > + (list (partition->user-partition esp-partition)) > + '()) > + (create-adjacent-partitions! disk > + new-partitions* > + #:last-partition-end > + (or end-esp-partition 0)))))) Perhaps add something like this to the docstring of =E2=80=98auto-partition= !=E2=80=99: Return the complete list of partitions on DISK, including the ESP when it exists. Longer-term it would be good to audit Guile-Parted: it probably shouldn=E2=80=99t be possible for Guile-Parted to refer to =E2=80=9Cdefunct= =E2=80=9D Parted objects. Thank you for the quick response! Ludo=E2=80=99.