From: "Ludovic Courtès" <ludo@gnu.org>
To: Vagrant Cascadian <vagrant@debian.org>
Cc: 44491@debbugs.gnu.org
Subject: bug#44491: Support GUIX_DISABLE_NETWORK_TESTS environment variable
Date: Mon, 07 Dec 2020 08:55:04 +0100 [thread overview]
Message-ID: <87im9e2gpz.fsf@gnu.org> (raw)
In-Reply-To: <87eek6n1of.fsf@yucca> (Vagrant Cascadian's message of "Thu, 03 Dec 2020 11:13:04 -0800")
Hi!
Vagrant Cascadian <vagrant@debian.org> skribis:
> On 2020-12-03, Ludovic Courtès wrote:
>> Should we close this issue now that you found the RES_OPTIONS=attempts:0
>> trick, or do you think we should still keep the refactoring bits?
>
> Well, it's three cases of copy-paste code, and one nearly identical but
> inverted. Someone once suggested to me to refactor on the third instance
> of copy-pasted code...
>
> Having common tests makes it a little easier to add to new tests in the
> future with the same code, and if there's ever a change in the
> underlying code, you fix it in once place. It also opens the door to
> adding other common functions, if it comes up.
>
> So I'd say it's worth applying, though also would be ok with leaving as
> is and just taking advantage of the RES_OPTIONS=attempts:0 workaround.
Makes sense to me. I’ll let you push it or let me know if you prefer me
to do it.
Thanks!
Ludo’.
prev parent reply other threads:[~2020-12-07 7:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 21:30 bug#44491: Support GUIX_DISABLE_NETWORK_TESTS environment variable Vagrant Cascadian
2020-11-08 17:46 ` Ludovic Courtès
2020-11-10 18:13 ` Vagrant Cascadian
2020-11-10 21:26 ` Ludovic Courtès
2020-11-11 3:39 ` Vagrant Cascadian
2020-11-11 6:06 ` Vagrant Cascadian
2020-12-03 17:09 ` Ludovic Courtès
2020-12-03 19:13 ` Vagrant Cascadian
2020-12-07 7:55 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im9e2gpz.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=44491@debbugs.gnu.org \
--cc=vagrant@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).