From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0PjeOR7gzV9daQAA0tVLHw (envelope-from ) for ; Mon, 07 Dec 2020 07:56:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yMGzNR7gzV/ncQAAB5/wlQ (envelope-from ) for ; Mon, 07 Dec 2020 07:56:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4FDC09403A7 for ; Mon, 7 Dec 2020 07:56:14 +0000 (UTC) Received: from localhost ([::1]:47172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmBNV-00028y-Aq for larch@yhetil.org; Mon, 07 Dec 2020 02:56:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmBNL-00028p-Ri for bug-guix@gnu.org; Mon, 07 Dec 2020 02:56:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmBNK-00041Q-Et for bug-guix@gnu.org; Mon, 07 Dec 2020 02:56:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmBNK-0002Ls-Dw for bug-guix@gnu.org; Mon, 07 Dec 2020 02:56:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44491: Support GUIX_DISABLE_NETWORK_TESTS environment variable Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 07 Dec 2020 07:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44491 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Vagrant Cascadian Received: via spool by 44491-submit@debbugs.gnu.org id=B44491.16073277148982 (code B ref 44491); Mon, 07 Dec 2020 07:56:02 +0000 Received: (at 44491) by debbugs.gnu.org; 7 Dec 2020 07:55:14 +0000 Received: from localhost ([127.0.0.1]:52234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmBMX-0002Kn-Rx for submit@debbugs.gnu.org; Mon, 07 Dec 2020 02:55:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmBMW-0002Kc-RA for 44491@debbugs.gnu.org; Mon, 07 Dec 2020 02:55:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50484) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmBMR-0003YA-5m; Mon, 07 Dec 2020 02:55:07 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=46438 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kmBMQ-0004am-CP; Mon, 07 Dec 2020 02:55:06 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87k0uy6um8.fsf@yucca> <87y2jbu4gx.fsf@gnu.org> <87k0utt6zt.fsf@yucca> <87wnysnbs6.fsf@gnu.org> <87h7pwtvde.fsf@yucca> <87eel0tok1.fsf@yucca> <87sg8mbyuz.fsf@gnu.org> <87eek6n1of.fsf@yucca> Date: Mon, 07 Dec 2020 08:55:04 +0100 In-Reply-To: <87eek6n1of.fsf@yucca> (Vagrant Cascadian's message of "Thu, 03 Dec 2020 11:13:04 -0800") Message-ID: <87im9e2gpz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44491@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.80 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 4FDC09403A7 X-Spam-Score: -2.80 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: M24yzXDDyP9B Hi! Vagrant Cascadian skribis: > On 2020-12-03, Ludovic Court=C3=A8s wrote: >> Should we close this issue now that you found the RES_OPTIONS=3Dattempts= :0 >> trick, or do you think we should still keep the refactoring bits? > > Well, it's three cases of copy-paste code, and one nearly identical but > inverted. Someone once suggested to me to refactor on the third instance > of copy-pasted code... > > Having common tests makes it a little easier to add to new tests in the > future with the same code, and if there's ever a change in the > underlying code, you fix it in once place. It also opens the door to > adding other common functions, if it comes up. > > So I'd say it's worth applying, though also would be ok with leaving as > is and just taking advantage of the RES_OPTIONS=3Dattempts:0 workaround. Makes sense to me. I=E2=80=99ll let you push it or let me know if you pref= er me to do it. Thanks! Ludo=E2=80=99.