* bug#19044: 'guix-register -p' should perform deduplication
@ 2014-11-13 16:56 Ludovic Courtès
2015-06-10 12:13 ` Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2014-11-13 16:56 UTC (permalink / raw)
To: 19044
When used with -p (as is the case when building a disk/VM image),
‘guix-register’ doesn’t do any deduplication in the target store, as
noted in the source:
/* XXX: When PREFIX is non-empty, store->linksDir points to the original
store's '.links' directory, which means 'optimisePath' would try to link
to that instead of linking to the target store. Thus, disable
deduplication in this case. */
if (optimize && prefix.empty ())
{
/* Make sure deduplication is enabled. */
settings.autoOptimiseStore = true;
foreach (ValidPathInfos::const_iterator, i, infos)
store->optimisePath (i->path);
}
This should be fixed, but may need to diverge slightly from upstream
libstore.
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#19044: 'guix-register -p' should perform deduplication
2014-11-13 16:56 bug#19044: 'guix-register -p' should perform deduplication Ludovic Courtès
@ 2015-06-10 12:13 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2015-06-10 12:13 UTC (permalink / raw)
To: 19044-done
ludo@gnu.org (Ludovic Courtès) skribis:
> When used with -p (as is the case when building a disk/VM image),
> ‘guix-register’ doesn’t do any deduplication in the target store
Fixed in 3697558.
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-10 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-13 16:56 bug#19044: 'guix-register -p' should perform deduplication Ludovic Courtès
2015-06-10 12:13 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).