From: Pierre Neidhardt <mail@ambrevar.xyz>
To: 35941@debbugs.gnu.org
Cc: Mathieu Othacehe <m.othacehe@gmail.com>
Subject: bug#35941: Newt installer failure when wifi name is #f
Date: Tue, 28 May 2019 10:59:04 +0200 [thread overview]
Message-ID: <87h89fj6p3.fsf@ambrevar.xyz> (raw)
[-- Attachment #1: Type: text/plain, Size: 1768 bytes --]
I've tried the installer today and it failed at the wifi selection,
printing a stack trace which allowed me to investigate. Since I could
not save it (shouldn't we dump it to a file by the way?), I've noted
down the following, roughly:
--8<---------------cut here---------------start------------->8---
In /gnu/installer/newt/wifi.scm:
204: (run-wifi-page)
(filter ...:145 (service)...
(#<<service> name: "foo" type: "wifi" path: "wifi_d..." ...)
147: (_ #<<service name: #f ...)
(string-null? #f)
--8<---------------cut here---------------end--------------->8---
Apparently it fails because a wifi service name is #f.
I can think of two fixes (untested). In wifi.scm:
--8<---------------cut here---------------start------------->8---
@@ -144,6 +144,7 @@ of <service-item> records present in LISTBOX."
(let ((services (connman-services)))
(filter (lambda (service)
(and (string=? (service-type service) "wifi")
+ (service-name service)
(not (string-null? (service-name service)))))
services)))
--8<---------------cut here---------------end--------------->8---
Or, more directly in connman.scm:
--8<---------------cut here---------------start------------->8---
@@ -108,7 +108,8 @@
(define-record-type* <service>
service make-service
service?
- (name service-name) ; string
+ (name service-name
+ (default ""))
(type service-type) ; string
(path service-path) ; string
(strength service-strength) ; integer
--8<---------------cut here---------------end--------------->8---
Thoughts?
--
Pierre Neidhardt
https://ambrevar.xyz/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next reply other threads:[~2019-05-28 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 8:59 Pierre Neidhardt [this message]
2019-05-28 9:15 ` bug#35941: Newt installer failure when wifi name is #f Danny Milosavljevic
2019-05-28 9:46 ` Pierre Neidhardt
2019-05-28 9:17 ` Mathieu Othacehe
2019-05-28 10:00 ` Pierre Neidhardt
2019-05-28 10:02 ` Pierre Neidhardt
2019-05-28 15:19 ` Ludovic Courtès
2019-05-28 17:51 ` Pierre Neidhardt
2019-05-29 7:50 ` Mathieu Othacehe
2019-05-29 9:03 ` Ludovic Courtès
2019-05-29 9:46 ` bug#35620: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h89fj6p3.fsf@ambrevar.xyz \
--to=mail@ambrevar.xyz \
--cc=35941@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).