From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Neidhardt Subject: bug#35941: Newt installer failure when wifi name is #f Date: Tue, 28 May 2019 10:59:04 +0200 Message-ID: <87h89fj6p3.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:60722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVXxn-0002vF-Kq for bug-guix@gnu.org; Tue, 28 May 2019 05:00:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVXxi-0006sZ-Iz for bug-guix@gnu.org; Tue, 28 May 2019 05:00:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41496) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVXxi-0006sR-GY for bug-guix@gnu.org; Tue, 28 May 2019 05:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hVXxi-0004AX-Au for bug-guix@gnu.org; Tue, 28 May 2019 05:00:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([209.51.188.92]:60538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVXwu-0002o9-VE for bug-guix@gnu.org; Tue, 28 May 2019 04:59:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVXwt-00068a-Rc for bug-guix@gnu.org; Tue, 28 May 2019 04:59:12 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:41177) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVXwt-00066f-M7 for bug-guix@gnu.org; Tue, 28 May 2019 04:59:11 -0400 List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 35941@debbugs.gnu.org Cc: Mathieu Othacehe --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I've tried the installer today and it failed at the wifi selection, printing a stack trace which allowed me to investigate. Since I could not save it (shouldn't we dump it to a file by the way?), I've noted down the following, roughly: =2D-8<---------------cut here---------------start------------->8--- In /gnu/installer/newt/wifi.scm: 204: (run-wifi-page) (filter ...:145 (service)... (#< name: "foo" type: "wifi" path: "wifi_d..." ...) 147: (_ #<8--- Apparently it fails because a wifi service name is #f. I can think of two fixes (untested). In wifi.scm: =2D-8<---------------cut here---------------start------------->8--- @@ -144,6 +144,7 @@ of records present in LISTBOX." (let ((services (connman-services))) (filter (lambda (service) (and (string=3D? (service-type service) "wifi") + (service-name service) (not (string-null? (service-name service))))) services))) =2D-8<---------------cut here---------------end--------------->8--- =20 Or, more directly in connman.scm: =2D-8<---------------cut here---------------start------------->8--- @@ -108,7 +108,8 @@ (define-record-type* service make-service service? =2D (name service-name) ; string + (name service-name + (default "")) (type service-type) ; string (path service-path) ; string (strength service-strength) ; integer =2D-8<---------------cut here---------------end--------------->8--- Thoughts? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlzs+FgACgkQm9z0l6S7 zH8YZggAlngA++B+PkbVOB9aku9vJAQSdI3y5+Fclza5rn13FtbkGITzBKQD+mr0 MGkF6vgTib74Z3Q8Lfy2Aitsr3H+nm1VdlUvPMrNuC88JEmZsE3HPtlbK/uMYqBo uTD94589+BGEPuGy/hV/AJKnam2+dYhCEcbrK4FVgmHoDyBVbIqVzb/Fd/AawcjW V8pfYtplMKK5TUxE64jx5SBO5WiZZbl9s1L4Iv4JCnU+yW6u+2Abt2A682tXxKXU 0MclWGlc+UAkYSzVvHJ4WRZ414eMd6DxOohqeP5XeEYnOUmZeI+NiStXfVv60pqq yBkf6rhspR2P6bFb3wJbhanvTwrNeg== =02pu -----END PGP SIGNATURE----- --=-=-=--