unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#36632: ungoogled-chromium needs font-gnu-freefont-ttf
@ 2019-07-13  0:22 Martin Becze
  2019-07-29 17:59 ` bug#36632: [Patch] add font-gnu-freefont-ttf propagated-inputs mjbecze
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Martin Becze @ 2019-07-13  0:22 UTC (permalink / raw)
  To: 36632


[-- Attachment #1.1: Type: text/plain, Size: 77 bytes --]

ungoogled-chromium will crash until font-gnu-freefont-ttf is installed.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#36632: [Patch] add font-gnu-freefont-ttf propagated-inputs
  2019-07-13  0:22 bug#36632: ungoogled-chromium needs font-gnu-freefont-ttf Martin Becze
@ 2019-07-29 17:59 ` mjbecze
  2019-08-05  1:25   ` mjbecze
  2019-08-01 22:16 ` bug#36632: (no subject) Martin Becze
  2019-08-05 19:36 ` bug#36632: ungoogled-chromium needs font-gnu-freefont-ttf Ricardo Wurmus
  2 siblings, 1 reply; 7+ messages in thread
From: mjbecze @ 2019-07-29 17:59 UTC (permalink / raw)
  To: 36632

hi this fixes bug 36632

---
 gnu/packages/chromium.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/chromium.scm b/gnu/packages/chromium.scm
index d072fc58ad..04ce780be0 100644
--- a/gnu/packages/chromium.scm
+++ b/gnu/packages/chromium.scm
@@ -35,6 +35,7 @@
   #:use-module (gnu packages compression)
   #:use-module (gnu packages cups)
   #:use-module (gnu packages curl)
+  #:use-module (gnu packages fonts)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages gcc)
@@ -763,6 +764,8 @@ from forcing GEXP-PROMISE."
        ("udev" ,eudev)
        ("valgrind" ,valgrind)
        ("vulkan-headers" ,vulkan-headers)))
+    (propagated-inputs
+      `(("font-gnu-freefont-ttf" ,font-gnu-freefont-ttf)))
 
     ;; Building Chromium takes ... a very long time.  On a single core,
a busy
     ;; mid-end x86 system may need more than 24 hours to complete the
build.
-- 
2.22.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* bug#36632: (no subject)
  2019-07-13  0:22 bug#36632: ungoogled-chromium needs font-gnu-freefont-ttf Martin Becze
  2019-07-29 17:59 ` bug#36632: [Patch] add font-gnu-freefont-ttf propagated-inputs mjbecze
@ 2019-08-01 22:16 ` Martin Becze
  2019-08-05 19:36 ` bug#36632: ungoogled-chromium needs font-gnu-freefont-ttf Ricardo Wurmus
  2 siblings, 0 replies; 7+ messages in thread
From: Martin Becze @ 2019-08-01 22:16 UTC (permalink / raw)
  To: 36632

bump :)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#36632: [Patch] add font-gnu-freefont-ttf propagated-inputs
  2019-07-29 17:59 ` bug#36632: [Patch] add font-gnu-freefont-ttf propagated-inputs mjbecze
@ 2019-08-05  1:25   ` mjbecze
  0 siblings, 0 replies; 7+ messages in thread
From: mjbecze @ 2019-08-05  1:25 UTC (permalink / raw)
  To: 36632

On 2019-07-29 13:59, mjbecze@riseup.net wrote:
> hi this fixes bug 36632
> 
> ---
>  gnu/packages/chromium.scm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/gnu/packages/chromium.scm b/gnu/packages/chromium.scm
> index d072fc58ad..04ce780be0 100644
> --- a/gnu/packages/chromium.scm
> +++ b/gnu/packages/chromium.scm
> @@ -35,6 +35,7 @@
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages cups)
>    #:use-module (gnu packages curl)
> +  #:use-module (gnu packages fonts)
>    #:use-module (gnu packages fontutils)
>    #:use-module (gnu packages freedesktop)
>    #:use-module (gnu packages gcc)
> @@ -763,6 +764,8 @@ from forcing GEXP-PROMISE."
>         ("udev" ,eudev)
>         ("valgrind" ,valgrind)
>         ("vulkan-headers" ,vulkan-headers)))
> +    (propagated-inputs
> +      `(("font-gnu-freefont-ttf" ,font-gnu-freefont-ttf)))
>  
>      ;; Building Chromium takes ... a very long time.  On a single core,
> a busy
>      ;; mid-end x86 system may need more than 24 hours to complete the
> build.


bump bump :)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#36632: ungoogled-chromium needs font-gnu-freefont-ttf
  2019-07-13  0:22 bug#36632: ungoogled-chromium needs font-gnu-freefont-ttf Martin Becze
  2019-07-29 17:59 ` bug#36632: [Patch] add font-gnu-freefont-ttf propagated-inputs mjbecze
  2019-08-01 22:16 ` bug#36632: (no subject) Martin Becze
@ 2019-08-05 19:36 ` Ricardo Wurmus
  2019-08-21 10:34   ` Martin Becze
  2 siblings, 1 reply; 7+ messages in thread
From: Ricardo Wurmus @ 2019-08-05 19:36 UTC (permalink / raw)
  To: Martin Becze; +Cc: 36632


Hi Martin,

> ungoogled-chromium will crash until font-gnu-freefont-ttf is installed.

Thank you for reporting this problem and proposing a patch.

I’d prefer not to propagate any fonts.  Do you happen to know what the
mechanism underlying the fix is?  Why does this fix the problem?  Why
does it crash in the first place?

Is this at all related to a stale font cache, perhaps?

-- 
Ricardo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#36632: ungoogled-chromium needs font-gnu-freefont-ttf
  2019-08-05 19:36 ` bug#36632: ungoogled-chromium needs font-gnu-freefont-ttf Ricardo Wurmus
@ 2019-08-21 10:34   ` Martin Becze
  2019-08-21 20:38     ` Ricardo Wurmus
  0 siblings, 1 reply; 7+ messages in thread
From: Martin Becze @ 2019-08-21 10:34 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: 36632

On 2019-08-05 15:36, Ricardo Wurmus wrote:
> Hi Martin,
> 
>> ungoogled-chromium will crash until font-gnu-freefont-ttf is installed.
> 
> Thank you for reporting this problem and proposing a patch.
> 
> I’d prefer not to propagate any fonts.  Do you happen to know what the
> mechanism underlying the fix is?  Why does this fix the problem?  Why
> does it crash in the first place?
> 
> Is this at all related to a stale font cache, perhaps?

So i got a chance to dig into this a bit. chromium needs a ttf font and
there are no fonts installed yet, so defaintly not a stale cache issue.
Chrome is crashing here
https://chromium.googlesource.com/chromium/src/+/master/ui/gfx/platform_font_skia.cc#97
Its using fontconfig i think. I have no idea how to get chromium to read
fonts from a custom path.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#36632: ungoogled-chromium needs font-gnu-freefont-ttf
  2019-08-21 10:34   ` Martin Becze
@ 2019-08-21 20:38     ` Ricardo Wurmus
  0 siblings, 0 replies; 7+ messages in thread
From: Ricardo Wurmus @ 2019-08-21 20:38 UTC (permalink / raw)
  To: Martin Becze; +Cc: 36632


Hi Martin,

> So i got a chance to dig into this a bit. chromium needs a ttf font and
> there are no fonts installed yet, so defaintly not a stale cache issue.
> Chrome is crashing here
> https://chromium.googlesource.com/chromium/src/+/master/ui/gfx/platform_font_skia.cc#97
> Its using fontconfig i think. I have no idea how to get chromium to read
> fonts from a custom path.

Can we arrange for a default font to be returned by fontconfig?  Perhaps
the fix is not needed in Chromium but in fontconfig or our profile hooks?

-- 
Ricardo

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-08-21 20:54 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-13  0:22 bug#36632: ungoogled-chromium needs font-gnu-freefont-ttf Martin Becze
2019-07-29 17:59 ` bug#36632: [Patch] add font-gnu-freefont-ttf propagated-inputs mjbecze
2019-08-05  1:25   ` mjbecze
2019-08-01 22:16 ` bug#36632: (no subject) Martin Becze
2019-08-05 19:36 ` bug#36632: ungoogled-chromium needs font-gnu-freefont-ttf Ricardo Wurmus
2019-08-21 10:34   ` Martin Becze
2019-08-21 20:38     ` Ricardo Wurmus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).