* bug#62303: guix style frequently wraps lines beyond 80 characters limit
@ 2023-03-20 21:20 Maxim Cournoyer
2023-03-21 3:38 ` Maxim Cournoyer
0 siblings, 1 reply; 2+ messages in thread
From: Maxim Cournoyer @ 2023-03-20 21:20 UTC (permalink / raw)
To: 62303
Hello Guix,
The "guix style" command appears to be too lenient on our maximum width
limit; it frequently overflows the 80 characters limit, as demonstrated
in the following example:
Before (max width: 77 characters)
--8<---------------cut here---------------start------------->8---
(define-public emacs-transient
(let ((commit "0ae0de43590b5b6984a83f9e044e7c426455ac6e")
(revision "1"))
(package
(name "emacs-transient")
(version (git-version "0.3.7" revision commit))
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/magit/transient")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32 "0c7wbd0j0b802bzdpdkrx2q7wm7b9s56rk554dnadkpywhmdiqwn"))))
(build-system emacs-build-system)
(arguments
`(#:tests? #f ;no test suite
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'build-info-manual
(lambda _
(invoke "make" "info")
;; Move the info file to lisp so that it gets installed by the
;; emacs-build-system.
(rename-file "docs/transient.info" "lisp/transient.info")))
(add-after 'build-info-manual 'enter-lisp-directory
(lambda _
(chdir "lisp"))))))
(native-inputs
(list texinfo))
(propagated-inputs
(list emacs-dash))
(home-page "https://magit.vc/manual/transient")
(synopsis "Transient commands in Emacs")
(description "Taking inspiration from prefix keys and prefix arguments
in Emacs, Transient implements a similar abstraction involving a prefix
command, infix arguments and suffix commands. We could call this abstraction
a \"transient command\", but because it always involves at least two
commands (a prefix and a suffix) we prefer to call it just a \"transient\".")
(license license:gpl3+))))
--8<---------------cut here---------------end--------------->8---
After (max width: 86 characters)
--8<---------------cut here---------------start------------->8---
(define-public emacs-transient
(let ((commit "0ae0de43590b5b6984a83f9e044e7c426455ac6e")
(revision "1"))
(package
(name "emacs-transient")
(version (git-version "0.3.7" revision commit))
(source (origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/magit/transient")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32
"0c7wbd0j0b802bzdpdkrx2q7wm7b9s56rk554dnadkpywhmdiqwn"))))
(build-system emacs-build-system)
(arguments
`(#:tests? #f ;no test suite
#:phases (modify-phases %standard-phases
(add-after 'unpack 'build-info-manual
(lambda _
(invoke "make" "info")
;; Move the info file to lisp so that it gets installed by the
;; emacs-build-system.
(rename-file "docs/transient.info"
"lisp/transient.info")))
(add-after 'build-info-manual 'enter-lisp-directory
(lambda _
(chdir "lisp"))))))
(native-inputs (list texinfo))
(propagated-inputs (list emacs-dash))
(home-page "https://magit.vc/manual/transient")
(synopsis "Transient commands in Emacs")
(description
"Taking inspiration from prefix keys and prefix arguments
in Emacs, Transient implements a similar abstraction involving a prefix
command, infix arguments and suffix commands. We could call this abstraction
a \"transient command\", but because it always involves at least two
commands (a prefix and a suffix) we prefer to call it just a \"transient\".")
(license license:gpl3+))))
--8<---------------cut here---------------end--------------->8---
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#62303: guix style frequently wraps lines beyond 80 characters limit
2023-03-20 21:20 bug#62303: guix style frequently wraps lines beyond 80 characters limit Maxim Cournoyer
@ 2023-03-21 3:38 ` Maxim Cournoyer
0 siblings, 0 replies; 2+ messages in thread
From: Maxim Cournoyer @ 2023-03-21 3:38 UTC (permalink / raw)
To: 62303
Hello,
Here's another example, on mygnuhealth (just committed):
--8<---------------cut here---------------start------------->8---
modified gnu/packages/medical.scm
@@ -46,19 +46,19 @@ (define-public mygnuhealth
"1jcrriccqzb4jx7zayhiqmpvi3cvfy3bbf9zr3m83878f94yww8j"))))
(build-system python-build-system)
(arguments
- (list
- #:imported-modules `(,@%python-build-system-modules
- ,@%qt-build-system-modules)
- #:modules `(((guix build qt-build-system) #:prefix qt:)
- (guix build python-build-system)
- (guix build utils))
- #:phases #~(modify-phases %standard-phases
- (add-after 'install 'qt-wrap
- (assoc-ref qt:%standard-phases 'qt-wrap))
- (add-before 'check 'env-setup
- (lambda _
- (mkdir-p "/tmp/mygh/")
- (setenv "HOME" "/tmp"))))))
+ (list #:imported-modules `(,@%python-build-system-modules ,@%qt-build-system-modules)
+ #:modules `(((guix build qt-build-system)
+ #:prefix qt:)
+ (guix build python-build-system)
+ (guix build utils))
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'install 'qt-wrap
+ (assoc-ref qt:%standard-phases
+ 'qt-wrap))
+ (add-before 'check 'env-setup
+ (lambda _
+ (mkdir-p "/tmp/mygh/")
+ (setenv "HOME" "/tmp"))))))
(native-inputs (list python-pyside-2))
(inputs (list bash-minimal
kirigami
--8<---------------cut here---------------end--------------->8---
The max width reaches 90 characters.
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-21 4:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-20 21:20 bug#62303: guix style frequently wraps lines beyond 80 characters limit Maxim Cournoyer
2023-03-21 3:38 ` Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).