From: "Ludovic Courtès" <ludo@gnu.org>
To: 68822-done@debbugs.gnu.org
Subject: bug#68822: Channel dependencies picked at the wrong commit
Date: Wed, 31 Jan 2024 09:14:32 +0100 [thread overview]
Message-ID: <87h6itj4wn.fsf@gnu.org> (raw)
In-Reply-To: <87r0hykcks.fsf@inria.fr> ("Ludovic Courtès"'s message of "Tue, 30 Jan 2024 17:31:15 +0100")
Ludovic Courtès <ludovic.courtes@inria.fr> skribis:
> When a channel is specified both implicitly, as the dependency of
> another channel, and explicitly, in the user-provided channels file, the
> “most specific” one wins—the one that has a non-#f ‘commit’ field.
>
> However, the dependencies of that channel may be read from the wrong
> one—the least-specific one. And they can be wrong.
This is fixed by 323b58ac18af8417d5b206288d09d9bb9385d7ae.
The patch changes the order in which channels and their dependencies are
traversed from depth-first to breadth-first. That gives more precedence
to user-supplied channels, which are likely more specific than what
appears in ‘.guix-channel’ files. So the fix kinda sidesteps the issue
but I think it makes sense to do it that way.
Ludo’.
prev parent reply other threads:[~2024-01-31 8:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 16:31 bug#68822: Channel dependencies picked at the wrong commit Ludovic Courtès
2024-01-31 8:14 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6itj4wn.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=68822-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).