From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id GDb0MJYBumW8qAAA62LTzQ:P1 (envelope-from ) for ; Wed, 31 Jan 2024 09:15:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id GDb0MJYBumW8qAAA62LTzQ (envelope-from ) for ; Wed, 31 Jan 2024 09:15:18 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=laVjQUUV; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706688918; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9wT0ulU2nusVjC6kRjvQ3rS4MTBHMEmODS+GaSMrOuI=; b=oG5v1o2KiaYzaug6GYpfhNeT+56vmCj3KqDyoGp9ekNEJ1nWWiZ9jddTFtWyzgWhz0AmCy QY33OUQ4mbnloHX6zpCX2Ao8st7+EocK/4FGhkiQ/Z2q+ECj1BVywkrEXbU/XjczlSIQ1Q qY2JGNiHqA4aoRgTiyONi0/qSJICC4eBNSpONdFfMCm03GLIAQmlpgREljuGxHtctG6Yg3 3xOKqk36XApb4o2LRGiweWlKr3JoIVH5zS7Jl+8qjM/rRZc2oxbSHljaEFRRLddiMr2u8s Si12v5Eoq6bm4uxKw0w5PKDIvogfWZXeuSah3uwBLlXOW3cIcgX43HGi6i/LSA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=laVjQUUV; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706688918; a=rsa-sha256; cv=none; b=R+3ZmDOAkxX/mgqxKe1d6wjr9EQ6ZMt0SqiOBjxC0/tRj3wFBgPdbp9ow2IpjzEo8uv9e0 NmYMDC1RcsTYKZfjJK+f9jPAo+I2sy415PxFbVFy8HI975/cLv2Ryg2KGHRRtU46wcje0w ypeK+yBV3Hzn5YfyagMt3zfgg3BhTCIo0Rbbs+A1wvK99E/s9VGJehe6Bw0/S+h/QJZX1Y HFso14fUzEyknjHdQyfKVDsdzl/MzYjB3cIc1eqvTqeGtGQEik6YENNvM+ZynY/lz7j0Wm KluZW/BQ3OOd3PqvQa9ps44vPbM4eBRm+joQaQDp9mnPQwGy6VbZ275OiWhdBA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 863EF5A79F for ; Wed, 31 Jan 2024 09:15:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rV5kE-0002Ww-JS; Wed, 31 Jan 2024 03:14:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rV5kD-0002Wh-Py for bug-guix@gnu.org; Wed, 31 Jan 2024 03:14:53 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rV5kD-0007nj-I3 for bug-guix@gnu.org; Wed, 31 Jan 2024 03:14:53 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rV5kM-0007D3-L0 for bug-guix@gnu.org; Wed, 31 Jan 2024 03:15:02 -0500 Subject: bug#68822: Channel dependencies picked at the wrong commit Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Wed, 31 Jan 2024 08:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 68822 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 68822-done@debbugs.gnu.org Mail-Followup-To: 68822@debbugs.gnu.org, ludo@gnu.org, ludovic.courtes@inria.fr Received: via spool by 68822-done@debbugs.gnu.org id=D68822.170668889527679 (code D ref 68822); Wed, 31 Jan 2024 08:15:02 +0000 Received: (at 68822-done) by debbugs.gnu.org; 31 Jan 2024 08:14:55 +0000 Received: from localhost ([127.0.0.1]:37390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rV5kF-0007CN-Dc for submit@debbugs.gnu.org; Wed, 31 Jan 2024 03:14:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rV5kA-0007C6-GL for 68822-done@debbugs.gnu.org; Wed, 31 Jan 2024 03:14:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rV5jv-0007kl-Ae for 68822-done@debbugs.gnu.org; Wed, 31 Jan 2024 03:14:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=9wT0ulU2nusVjC6kRjvQ3rS4MTBHMEmODS+GaSMrOuI=; b=laVjQUUVmJMqI9zTdp7E 6vOpuLmmC3x/wiGthYKYPLZvvxIkkdxldVJ0H1MAWvrYPHH6tVZ3KWp2BBdHsVflkPqndxoaJY3uW LP8UpCzXgqs7zkdMt4yoFobvdzB/upmfTUwVVKo3FaLBA1N1B7bb0S9xU6yNvhkB3NuwtwjpI69ga okKgx641wX8u32M8vhkXyUy1uWL1frUYalnmN1fQA3smtXImrJj6FSfyS29Up+zRMD1AA3U4dcdes xdurc94Davmnw4pbddpnfxN5jpv/MPPEY5qWAPx0ygfLWr2oE0tUXg38yRzp5N/rgp2NF0pdWQexN isbEjTkV2NdQfw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87r0hykcks.fsf@inria.fr> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 30 Jan 2024 17:31:15 +0100") References: <87r0hykcks.fsf@inria.fr> Date: Wed, 31 Jan 2024 09:14:32 +0100 Message-ID: <87h6itj4wn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.48 X-Migadu-Queue-Id: 863EF5A79F X-Spam-Score: -4.48 X-Migadu-Scanner: mx11.migadu.com X-TUID: ihVXL14GGwBP Ludovic Court=C3=A8s skribis: > When a channel is specified both implicitly, as the dependency of > another channel, and explicitly, in the user-provided channels file, the > =E2=80=9Cmost specific=E2=80=9D one wins=E2=80=94the one that has a non-#= f =E2=80=98commit=E2=80=99 field. > > However, the dependencies of that channel may be read from the wrong > one=E2=80=94the least-specific one. And they can be wrong. This is fixed by 323b58ac18af8417d5b206288d09d9bb9385d7ae. The patch changes the order in which channels and their dependencies are traversed from depth-first to breadth-first. That gives more precedence to user-supplied channels, which are likely more specific than what appears in =E2=80=98.guix-channel=E2=80=99 files. So the fix kinda sideste= ps the issue but I think it makes sense to do it that way. Ludo=E2=80=99.