From: Mathieu Othacehe <m.othacehe@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 41182@debbugs.gnu.org
Subject: bug#41182: Profile hooks ignore system and target
Date: Tue, 12 May 2020 10:35:50 +0200 [thread overview]
Message-ID: <87ftc5czyx.fsf@gmail.com> (raw)
In-Reply-To: <87k11idvkz.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 11 May 2020 23:13:00 +0200")
Hey Ludo,
> So I’m very much tempted to instead require each hook to take ‘system’
> and ‘#:target’ arguments and pass them to ‘gexp->derivation’. It’ll
> break the API, in case someone out there has custom profile hooks
> (unlikely given that it’s not really documented), but I’d say that’s OK.
>
> Thoughts?
What seems strange to me is that gexp->derivation has target set to
'current by default, so it should use the defined target. Now, that I
look at it, it's using "%current-target-system".
Would it make any difference to switch:
--8<---------------cut here---------------start------------->8---
(target -> (if (eq? target 'current)
(%current-target-system)
target))
--8<---------------cut here---------------end--------------->8---
to
--8<---------------cut here---------------start------------->8---
(target (if (eq? target 'current)
(current-target-system)
(return target)))
--8<---------------cut here---------------end--------------->8---
like for lower-object, gexp->file and gexp->script?
Regarding breaking the profile hooks API, it's fine by me.
Thanks for investigating this,
Mathieu
next prev parent reply other threads:[~2020-05-12 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 20:38 bug#41182: Profile hooks ignore system and target Ludovic Courtès
2020-05-11 21:13 ` Ludovic Courtès
2020-05-12 8:35 ` Mathieu Othacehe [this message]
2020-05-13 9:45 ` Jan Nieuwenhuizen
2020-05-13 10:37 ` Mathieu Othacehe
2020-05-14 12:24 ` Ludovic Courtès
2020-05-14 15:23 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftc5czyx.fsf@gmail.com \
--to=m.othacehe@gmail.com \
--cc=41182@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).