From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6LgaCO5ful4qNAAA0tVLHw (envelope-from ) for ; Tue, 12 May 2020 08:35:58 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UMCvF/xful5POQAAB5/wlQ (envelope-from ) for ; Tue, 12 May 2020 08:36:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EA2DF940068 for ; Tue, 12 May 2020 08:36:09 +0000 (UTC) Received: from localhost ([::1]:37238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYQOX-0000CU-EH for larch@yhetil.org; Tue, 12 May 2020 04:36:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYQOQ-0000C6-Be for bug-guix@gnu.org; Tue, 12 May 2020 04:36:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYQOQ-00081x-2V for bug-guix@gnu.org; Tue, 12 May 2020 04:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYQOP-0004TW-V8 for bug-guix@gnu.org; Tue, 12 May 2020 04:36:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#41182: Profile hooks ignore system and target Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 12 May 2020 08:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41182 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 41182-submit@debbugs.gnu.org id=B41182.158927255917194 (code B ref 41182); Tue, 12 May 2020 08:36:01 +0000 Received: (at 41182) by debbugs.gnu.org; 12 May 2020 08:35:59 +0000 Received: from localhost ([127.0.0.1]:54101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYQON-0004TG-Fa for submit@debbugs.gnu.org; Tue, 12 May 2020 04:35:59 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:53145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYQOM-0004T3-1s for 41182@debbugs.gnu.org; Tue, 12 May 2020 04:35:58 -0400 Received: by mail-wm1-f41.google.com with SMTP id m24so11162010wml.2 for <41182@debbugs.gnu.org>; Tue, 12 May 2020 01:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=l5sWVA0oGpxBbGwpzgQlc1sNHS+XLooJrDOTCHhS/2c=; b=d5vElUjx3NGxwo5qifGp2pNoYBX2gC7DnuTqK+TVdNRkqIHRtGVGWYI1dQJ7UnUH5H KLcHBogB5GVUE+uZ3PH8Ydaj16SFWpL6W0cUUNFGI7u44kgWTB26+o8BOzZJvJvUj0+E RNp+2H690BaQPdnu1FrMH/bvTnQuZvbTmQ4geeaeUQ+gMT+xkynN3E0OVQr0PZUt6RMI 7/HFTE+4nNQesXazG2TK7D8+tYaPlIxGChAdmBPXXZBcxNYWyKVMfzGdxqyCUIZQav1u BMjxwTlAf3kVJ1IuU8XkcdSAPmXkYqjvdAze55flyvLsbxNa1QRzPXt8FAUQWDtTF0Sq JoEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=l5sWVA0oGpxBbGwpzgQlc1sNHS+XLooJrDOTCHhS/2c=; b=qmOUsJJWhEZxP5N55nmH+3zBWUDiPP3FXD+WvR/EI7fLh908S1Hl22W+fqVEudj1sB MlMuqhcXAlCm+DJsMiwOVhzBThLPOtt64GJblaTjqDTOR68MUmxM0P///uXzWYlbvdx2 iwRQA8ejwGX6GLzObC/ame/Gt8Ztgm0ztPb5ravwmciY2DZC5aPf3A3gPHhpMXl8bUOb U6W2UlrSrg7QHTybbFZ4NZETwMqYvqjeoyYoRl57P/DENVjrDxlwEtzqKTx3xesK3AVv pJNgrRaOFnPR7eLwBhWN0UZyCoVFyNBOMbchyMbOUDQYY9Ee85Lt00MDmLi0+GZW0loD EHlA== X-Gm-Message-State: AGi0PubwmltOIifPJGLUdHkvyRCxoo8m5wnFVw0jzQL0uz6p8XxvqiXW UbNZFECuZZ1rBM+7ohS246M= X-Google-Smtp-Source: APiQypJPj+PvU/T6OlasqhvM1H4V2Nc2xDIZAXNCBmD2w8AnSwv9MuYcSagpCCMUe4/uOwwogQqCnw== X-Received: by 2002:a7b:c253:: with SMTP id b19mr15483175wmj.110.1589272551987; Tue, 12 May 2020 01:35:51 -0700 (PDT) Received: from meru ([2a01:cb18:832e:5f00:fd66:fbb0:b5a6:36b6]) by smtp.gmail.com with ESMTPSA id r11sm10357048wro.15.2020.05.12.01.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 01:35:51 -0700 (PDT) From: Mathieu Othacehe References: <87a72f8qzi.fsf@inria.fr> <87k11idvkz.fsf@gnu.org> Date: Tue, 12 May 2020 10:35:50 +0200 In-Reply-To: <87k11idvkz.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 11 May 2020 23:13:00 +0200") Message-ID: <87ftc5czyx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41182@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 X-Spam-Score: 0.09 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=d5vElUjx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Scan-Result: default: False [0.09 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.54015824313523]; TO_DN_SOME(0.00)[]; R_DKIM_REJECT(1.00)[gmail.com:s=20161025]; FREEMAIL_FROM(0.00)[gmail.com]; DWL_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.07), country: US(-0.00), ip: 209.51.188.17(-0.54)]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24]; DKIM_TRACE(0.00)[gmail.com:-]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[mothacehe@gmail.com,bug-guix-bounces@gnu.org]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; SPF_REPUTATION_HAM(0.00)[-0.56490958921428]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[41182@debbugs.gnu.org]; HAS_LIST_UNSUB(-0.01)[]; DNSWL_BLOCKED(0.00)[209.51.188.17:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.51.188.17:from]; RCVD_COUNT_SEVEN(0.00)[9]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : SPF not aligned (relaxed),none] X-TUID: 4GwABwYAtVg3 Hey Ludo, > So I=E2=80=99m very much tempted to instead require each hook to take =E2= =80=98system=E2=80=99 > and =E2=80=98#:target=E2=80=99 arguments and pass them to =E2=80=98gexp->= derivation=E2=80=99. It=E2=80=99ll > break the API, in case someone out there has custom profile hooks > (unlikely given that it=E2=80=99s not really documented), but I=E2=80=99d= say that=E2=80=99s OK. > > Thoughts? What seems strange to me is that gexp->derivation has target set to 'current by default, so it should use the defined target. Now, that I look at it, it's using "%current-target-system". Would it make any difference to switch: --8<---------------cut here---------------start------------->8--- (target -> (if (eq? target 'current) (%current-target-system) target)) --8<---------------cut here---------------end--------------->8--- to --8<---------------cut here---------------start------------->8--- (target (if (eq? target 'current) (current-target-system) (return target))) --8<---------------cut here---------------end--------------->8--- like for lower-object, gexp->file and gexp->script? Regarding breaking the profile hooks API, it's fine by me. Thanks for investigating this, Mathieu