From: Marius Bakke <mbakke@fastmail.com>
To: "Diego Nicola Barbato" <dnbarbato@posteo.de>,
"Ludovic Courtès" <ludo@gnu.org>
Cc: 41116-done@debbugs.gnu.org, Alex Sassmannshausen <alex@komputilo.eu>
Subject: bug#41116: Guix deploy fails with new version of Herd
Date: Fri, 08 May 2020 15:44:18 +0200 [thread overview]
Message-ID: <87eeru35jh.fsf@devup.no> (raw)
In-Reply-To: <875zd7na9y.fsf@GlaDOS.home>
[-- Attachment #1: Type: text/plain, Size: 2988 bytes --]
Diego Nicola Barbato <dnbarbato@posteo.de> writes:
> Hey,
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hello Alex & Marius,
>>
>> Marius Bakke <mbakke@fastmail.com> skribis:
>>
>>> Alex Sassmannshausen via Bug reports for GNU Guix <bug-guix@gnu.org>
>>> writes:
>>>
>>>> Hello,
>>>>
>>>> I maintain a number of servers using Guix deploy. It seems that the
>>>> recent upgrade to Herd in Guix, and specifically commit
>>>> 4c0cc7bed3de2c0e2d3a6e95b88693941e839eec might have introduced a bug.
>>>>
>>>> From my testing, guix deploy currently consistently fails with:
>>>> -----------------8<----------------------------->8-------------------
>>>> ice-9/boot-9.scm:1667:16: In procedure raise-exception:
>>>> ERROR:
>>>> 1. &inferior-exception:
>>>> arguments: (srfi-34 #<inferior-object #<condition &action-exception-error [service: root action: eval key: keyword-argument-error args: ("#<procedure 7fe24816e240 at shepherd/service.scm:903:4 (command #:key user group directory environment-variables pid-file pid-file-timeout log-file) | (program . program-args)>" "Unrecognized keyword" () (#:file-creation-mask))] 7eff2bd7be00>>)
>>>> inferior: #f
>>>> stack: ()
>>>> -----------------8<----------------------------->8-------------------
>>>>
>>>> A workaround is to build the system configuration locally on the target
>>>> server, then to reconfigure. It will still error at the same place, but
>>>> at this point, after restarting the server, the new version of Herd will
>>>> be running and both deploy and reconfigure will work.
>>>>
>>>> I don't know what a good solution to this could be, but it may be
>>>> something we need to consider in future development of Herd.
>>>
>>> This issue has been reported by a number of users on IRC. I think the
>>> problem is that the the #:file-creation-mask keyword requires support
>>> from the running Shepherd, which may not have it yet. I think we should
>>> revert commit 4c0cc7bed3de2c0e2d3a6e95b88693941e839eec until we find a
>>> smooth upgrade path. Can you try it and push if that fixes guix deploy?
>>
>> I’ve reverted the patch in 5aa4d2dcf2f4f8786358feb45338893ed08a4cd9.
>>
>> Diego: I guess we can reinstate the patch “later”, once Shepherd 0.8 can
>> be considered widespread.
>
> I'm sorry I broke reconfigure and deploy. I didn't consider testing
> upgrading from before Shepherd 0.8 to after my change and I didn't even
> think of deploy. Going forth I'll leave messing with core functionality
> to the pros.
Mistakes happen, don't worry about it.
One thing that would be really useful and can prevent such situations in
the future is to have a "system test" that tries to run reconfigure from
the latest released version of Guix (currently 1.1.0).
There are already a few Shepherd tests in gnu/tests/base.scm and
gnu/tests/reconfigure.scm that can be used as inspiration.
Food for thought, patches welcome, etc. :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-05-08 13:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 22:21 bug#41116: Guix deploy fails with new version of Herd Alex Sassmannshausen via Bug reports for GNU Guix
2020-05-06 22:38 ` bug#41116: A naive proposal for a solution Alex Sassmannshausen via Bug reports for GNU Guix
2020-05-06 22:45 ` bug#41116: Guix deploy fails with new version of Herd Marius Bakke
2020-05-07 11:37 ` Alex Sassmannshausen via Bug reports for GNU Guix
2020-05-07 12:27 ` Ludovic Courtès
2020-05-07 13:29 ` Diego Nicola Barbato
2020-05-08 13:44 ` Marius Bakke [this message]
2020-05-09 23:23 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeru35jh.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=41116-done@debbugs.gnu.org \
--cc=alex@komputilo.eu \
--cc=dnbarbato@posteo.de \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).