From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Raghav Gururajan <rg@raghavgururajan.name>,
56382@debbugs.gnu.org, 20255@debbugs.gnu.org,
Morgan.J.Smith@outlook.com
Subject: bug#20255: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Date: Mon, 18 Jul 2022 07:21:40 -0400 [thread overview]
Message-ID: <87edyism2j.fsf@gmail.com> (raw)
In-Reply-To: <87k08a3h0s.fsf@gnu.org> ("Ludovic Courtès"'s message of "Mon, 18 Jul 2022 11:29:55 +0200")
Hello!
Ludovic Courtès <ludo@gnu.org> writes:
[...]
>>> Right, so the proposed patch (adding ‘hicolor-icon-theme’ to ‘inputs’,
>>> not ‘propagated-inputs’) shouldn’t make any difference I guess?
>>
>> I think it works as inputs because of our wrappers (perhaps
>> XDG_DATA_DIRS)? But it's kind at odds with our policy which is to let
>> users manage icons themselves.
>
> Yeah.
>
>> Probably because of #20255 that wouldn't help currently (system and user
>> profiles are not merged), but if we fixed that bug we could make the
>> situation better by adding 'hicolor-icon-theme' to the default packages
>> of our desktop system templates.
>
> Right.
>
> BTW, the reason the solution at <https://issues.guix.gnu.org/20255#12>
> was rejected could be revisited. Since that time, search paths made it
> into the manifest itself, which brings a speed up:
>
> $ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches '
> $ time guix package -p ~/.guix-home/profile -p /run/current-system/profile --search-paths > /dev/null
>
> real 0m0.540s
> user 0m0.131s
> sys 0m0.063s
> $ time guix package -p ~/.guix-home/profile -p /run/current-system/profile --search-paths > /dev/null
>
> real 0m0.135s
> user 0m0.130s
> sys 0m0.024s
>
> Thoughts?
Re-reading the bug report, we had come up with a blueprint of a possible
solution but failed short of implementing it [0]
[0] https://issues.guix.gnu.org/20255#35
Even the --search-paths command become 0.2 s, I don't think it'll
satisfy all parties, so the solution above still has merit, I think.
Perhaps we should try to implement it, unless you see a problem with it.
Thanks,
Maxim
next parent reply other threads:[~2022-07-18 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87sfn6asfz.fsf@gnu.org>
[not found] ` <DM5PR03MB31633E3B8D7FB6CF9CD13BE5C5BE9@DM5PR03MB3163.namprd03.prod.outlook.com>
[not found] ` <ff47ca4d7bfe0148f827dac382ca6211@raghavgururajan.name>
[not found] ` <877d4e8r79.fsf@gnu.org>
[not found] ` <87tu7hsupr.fsf@gmail.com>
[not found] ` <87k08a3h0s.fsf@gnu.org>
2022-07-18 11:21 ` Maxim Cournoyer [this message]
[not found] ` <20220718133318.GA2771@LionPure>
2022-07-19 8:29 ` bug#20255: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edyism2j.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=20255@debbugs.gnu.org \
--cc=56382@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
--cc=ludo@gnu.org \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).