From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4AO7JJZC1WJkZwAAbAwnHQ (envelope-from ) for ; Mon, 18 Jul 2022 13:23:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YChyI5ZC1WL4BgAAG6o9tA (envelope-from ) for ; Mon, 18 Jul 2022 13:23:02 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 52E98BFF7 for ; Mon, 18 Jul 2022 13:23:02 +0200 (CEST) Received: from localhost ([::1]:49316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDOq5-0007Qo-H1 for larch@yhetil.org; Mon, 18 Jul 2022 07:23:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDOp9-0006su-7K for bug-guix@gnu.org; Mon, 18 Jul 2022 07:22:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51562) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDOp8-0000fK-Uo for bug-guix@gnu.org; Mon, 18 Jul 2022 07:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDOp8-00086E-RD for bug-guix@gnu.org; Mon, 18 Jul 2022 07:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#20255: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 18 Jul 2022 11:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20255 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Raghav Gururajan , 56382@debbugs.gnu.org, 20255@debbugs.gnu.org, Morgan.J.Smith@outlook.com Received: via spool by 20255-submit@debbugs.gnu.org id=B20255.165814331431101 (code B ref 20255); Mon, 18 Jul 2022 11:22:02 +0000 Received: (at 20255) by debbugs.gnu.org; 18 Jul 2022 11:21:54 +0000 Received: from localhost ([127.0.0.1]:49318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDOp0-00085Y-0K for submit@debbugs.gnu.org; Mon, 18 Jul 2022 07:21:54 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]:43727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDOou-00084y-HW; Mon, 18 Jul 2022 07:21:49 -0400 Received: by mail-qt1-f175.google.com with SMTP id a9so8409974qtw.10; Mon, 18 Jul 2022 04:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=QnebC4v9Of8Z3sryzCjXmI7hUlxj3D7aIiV4baEPYEg=; b=d/qIEgAl6iboPOFeEeXl/Lq8KjdjDD28iQ89s+OHO/yETXEqFeGXPKr6YQIp9mqAoJ 7tAQIefG8teGuX1hDZpH+WECWtulXRmaNGdK5CiLlbk8MqFBGUVlTVltxnPAYO/NK4mG 1Xv48dy35XByRgzFErKiwHkQTHd1YSl3ixt4KY3p4aEUNTi8vrkto/DHMbIAgEOMe0l1 SJWY/6BBlUyX6LSqSM0/sw7zYYea7gLrH68ftjSKvW0cW6OkqOjYMQR9v1tSzSevXhXj FC0Ttf3PdWtrcr5OazylVrZQU3hXAV1s+Qq1Ri+LorrZ3SCFLTOIaqxnL29TU9uC+xF0 ezqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=QnebC4v9Of8Z3sryzCjXmI7hUlxj3D7aIiV4baEPYEg=; b=2eZrSYjMQVCBX+y+tWVNtl1jBXX6dRiB+A7FGFXgedqPfiCIJms8cE4dqHo2cbMJv2 UbnmVvmJBooUN1pWi2sVqnmBkpraqjAuGpG7TcCI1H3CgLLI2j5or+MX/fShfWrKCrEz pjOD+oap9tZ14+eLRA0mm4paguGK6AN7vW/EJ8w7b5yyxxGm6pr1ucqlVBxB/DTuOeqY a8i5LgqGuAZgRdo8zugw869nAcknUtY4E/XRMVx932sneWakh32yybJKMhCQV0f7OBZZ B2PpZ0qpvuEtaIb49CiHo+swmsR5pXRNe1mFzpJYK1OY64K37vtUAZgtACZrIRqBlPl1 VExw== X-Gm-Message-State: AJIora/1SOlCWi7MqpMdg8XiA4SfqmgllRbh405B+4iaDcX644bknXeF 8E1urWOtSE1b/NgpgX+aINYnMPU5py5QdQ== X-Google-Smtp-Source: AGRyM1uNc5OFOLHhen7XP7oZJWULBsvfHVsMk7MF4nyXqOJQnA/oyrF+6ECCvdc5AKHNLYM3hUWRSA== X-Received: by 2002:a05:622a:30c:b0:31e:bc56:98e4 with SMTP id q12-20020a05622a030c00b0031ebc5698e4mr20909493qtw.679.1658143302732; Mon, 18 Jul 2022 04:21:42 -0700 (PDT) Received: from hurd (dsl-205-151-56-157.b2b2c.ca. [205.151.56.157]) by smtp.gmail.com with ESMTPSA id z25-20020ac87cb9000000b0031d283f4c4dsm8630169qtv.60.2022.07.18.04.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 04:21:42 -0700 (PDT) From: Maxim Cournoyer References: <87sfn6asfz.fsf@gnu.org> <877d4e8r79.fsf@gnu.org> <87tu7hsupr.fsf@gmail.com> <87k08a3h0s.fsf@gnu.org> Date: Mon, 18 Jul 2022 07:21:40 -0400 In-Reply-To: <87k08a3h0s.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 18 Jul 2022 11:29:55 +0200") Message-ID: <87edyism2j.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658143382; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QnebC4v9Of8Z3sryzCjXmI7hUlxj3D7aIiV4baEPYEg=; b=M8EALD8wdgJPV3vTLpSljhxI+ze08XNRvOI2ihcZvfNgaV6KzZs2zLUON65OQKuOugJLfj 9XYPppI2oV5hg1FkLj4Y+3wStF/ujVRoD1meQU8hW2TLqQJrNt/117RAmYBxn1YHfZdSgl 9LxO3ZKDLOUnhA+UWJgwutDqaDgY0BGwOPF9WxTU2xi+9QCtLf9ypG5//TQ3WEEVgIm++q 3dvEZTwG5IpnIIM99jUjNkxk9SICBLnExg6gTg52ERaoXg9VQ01IbnusHhluxEGX+5Tv8K cG/z4KsmQcqiXwBeIF/MtxpRShhcRLE77NWWP0A1OzdmCXuutGQNKXCw1RahSA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658143382; a=rsa-sha256; cv=none; b=KJRxvhwtX6XR4WdiQqqbWqsSRFWjarR8bdIik+UJLmOkouku64sK/Scl0hpSkyYIYEDlCE Ezqmi60s3Iy6UIqlIkQYr84y23pMFDPGtseUldqpuJFdjRelCpo3HhSPnTnONo0revhF77 SU2XjwHstdDeusyduAxjXK6v89YdExe25TzJLQEEMav22a9jzPJbe8m7Bep3+GTkSbAW94 v4qGYad7XYc4K4bSgosqBuR1sSpzACiTvKRR924HNZB8gG39jKEDbSSRvmbm9+rpJG68st nvCmhKobVQCN0bH0XXpABrrhuQmLwTg7RRZDEw14FYwFYrxciohHxL7vkpQO8Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="d/qIEgAl"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.07 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="d/qIEgAl"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 52E98BFF7 X-Spam-Score: 6.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: Arx2qyIxQXF8 Hello! Ludovic Court=C3=A8s writes: [...] >>> Right, so the proposed patch (adding =E2=80=98hicolor-icon-theme=E2=80= =99 to =E2=80=98inputs=E2=80=99, >>> not =E2=80=98propagated-inputs=E2=80=99) shouldn=E2=80=99t make any dif= ference I guess? >> >> I think it works as inputs because of our wrappers (perhaps >> XDG_DATA_DIRS)? But it's kind at odds with our policy which is to let >> users manage icons themselves. > > Yeah. > >> Probably because of #20255 that wouldn't help currently (system and user >> profiles are not merged), but if we fixed that bug we could make the >> situation better by adding 'hicolor-icon-theme' to the default packages >> of our desktop system templates. > > Right. > > BTW, the reason the solution at > was rejected could be revisited. Since that time, search paths made it > into the manifest itself, which brings a speed up: > > $ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches ' > $ time guix package -p ~/.guix-home/profile -p /run/current-system/profil= e --search-paths > /dev/null > > real 0m0.540s > user 0m0.131s > sys 0m0.063s > $ time guix package -p ~/.guix-home/profile -p /run/current-system/profil= e --search-paths > /dev/null > > real 0m0.135s > user 0m0.130s > sys 0m0.024s > > Thoughts? Re-reading the bug report, we had come up with a blueprint of a possible solution but failed short of implementing it [0] [0] https://issues.guix.gnu.org/20255#35 Even the --search-paths command become 0.2 s, I don't think it'll satisfy all parties, so the solution above still has merit, I think. Perhaps we should try to implement it, unless you see a problem with it. Thanks, Maxim