unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#70111: Gnome 44: Dark Theme not Working
@ 2024-03-31 18:05 Dariqq
  2024-04-03  3:46 ` Maxim Cournoyer
  2024-04-03  9:25 ` bug#70111: [PATCH] gnu: gnome-essential-extras: Propagate xdg-desktop-portal Dariqq
  0 siblings, 2 replies; 5+ messages in thread
From: Dariqq @ 2024-03-31 18:05 UTC (permalink / raw)
  To: 70111

Hi Guix,

Updated my system to Gnome 44 f5558ee0cc1a11a8b61d3f4d43f05dd79d53ac77 
and the dark style setting in Gnome no longer works (compared to Gnome 
42), i.e. apps like gnome-control-center and nautilus still have the 
light theme even though the setting is set to Dark.

The setting from the control-center is applied correctly:

  guix shell glib:bin -- gsettings get org.gnome.desktop.interface 
color-scheme
'prefer-dark'

"GTK_THEME" is unset, no extra config in ~/.config/gtk-*.0/settings.ini 
and also Application>Appeareance in Gnome Tweaks is set to Adwaita-Dark.

Some results from searching online suggest to install xdg-desktop-portal 
and adding that to the system profile and rebooting indeed makes the 
dark setting work as expected.

Should this be handled by the gnome-desktop-service-type, i.e. added by 
one of the gnome-meta-packages (probably gnome-essential-extras)?

Thanks.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#70111: Gnome 44: Dark Theme not Working
  2024-03-31 18:05 bug#70111: Gnome 44: Dark Theme not Working Dariqq
@ 2024-04-03  3:46 ` Maxim Cournoyer
  2024-04-03  9:25 ` bug#70111: [PATCH] gnu: gnome-essential-extras: Propagate xdg-desktop-portal Dariqq
  1 sibling, 0 replies; 5+ messages in thread
From: Maxim Cournoyer @ 2024-04-03  3:46 UTC (permalink / raw)
  To: Dariqq; +Cc: 70111

Hi,

Dariqq <dariqq@posteo.net> writes:

[...]

> Some results from searching online suggest to install
> xdg-desktop-portal and adding that to the system profile and rebooting
> indeed makes the dark setting work as expected.
>
> Should this be handled by the gnome-desktop-service-type, i.e. added
> by one of the gnome-meta-packages (probably gnome-essential-extras)?

A solution along these lines sound reasonable to me.  I think switching
to the dark theme should work out of the box if it's exposed in the UI.

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#70111: [PATCH] gnu: gnome-essential-extras: Propagate xdg-desktop-portal.
  2024-03-31 18:05 bug#70111: Gnome 44: Dark Theme not Working Dariqq
  2024-04-03  3:46 ` Maxim Cournoyer
@ 2024-04-03  9:25 ` Dariqq
  2024-04-03 18:11   ` Maxim Cournoyer
  1 sibling, 1 reply; 5+ messages in thread
From: Dariqq @ 2024-04-03  9:25 UTC (permalink / raw)
  To: 70111
  Cc: Dariqq, Liliana Marie Prikler, Maxim Cournoyer, Raghav Gururajan,
	Vivien Kraus

xdg-desktop-portal (and xdg-desktop-portal-gnome) is needed for the dark theme
in Gnome 44 to work properly.

* gnu/packages/gnome.scm (gnome-essential-extras)[propagated-inputs]: Add xdg-desktop-portal.

Change-Id: Id84626e6bc404e9607ee7f8f299ac90f24323081
---
 gnu/packages/gnome.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c8305b0dd8..7209a14e67 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -10306,6 +10306,7 @@ (define-public gnome-essential-extras
                             pulseaudio
                             shared-mime-info
                             system-config-printer
+                            xdg-desktop-portal
                             xdg-user-dirs
                             yelp
                             zenity))

base-commit: f26b42f6c07a00dd2cecb006846e672b88748b84
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#70111: [PATCH] gnu: gnome-essential-extras: Propagate xdg-desktop-portal.
  2024-04-03  9:25 ` bug#70111: [PATCH] gnu: gnome-essential-extras: Propagate xdg-desktop-portal Dariqq
@ 2024-04-03 18:11   ` Maxim Cournoyer
  2024-04-06  4:50     ` Liliana Marie Prikler
  0 siblings, 1 reply; 5+ messages in thread
From: Maxim Cournoyer @ 2024-04-03 18:11 UTC (permalink / raw)
  To: Dariqq; +Cc: Raghav Gururajan, Vivien Kraus, Liliana Marie Prikler, 70111

Hello,

Dariqq <dariqq@posteo.net> writes:

> xdg-desktop-portal (and xdg-desktop-portal-gnome) is needed for the dark theme
> in Gnome 44 to work properly.
>
> * gnu/packages/gnome.scm (gnome-essential-extras)[propagated-inputs]: Add xdg-desktop-portal.
>
> Change-Id: Id84626e6bc404e9607ee7f8f299ac90f24323081

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

Haven't tested it myself, but I trust the findings of Dariqq.

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#70111: [PATCH] gnu: gnome-essential-extras: Propagate xdg-desktop-portal.
  2024-04-03 18:11   ` Maxim Cournoyer
@ 2024-04-06  4:50     ` Liliana Marie Prikler
  0 siblings, 0 replies; 5+ messages in thread
From: Liliana Marie Prikler @ 2024-04-06  4:50 UTC (permalink / raw)
  To: Maxim Cournoyer, Dariqq; +Cc: 70111-done, Vivien Kraus, Raghav Gururajan

Am Mittwoch, dem 03.04.2024 um 14:11 -0400 schrieb Maxim Cournoyer:
> Hello,
> 
> Dariqq <dariqq@posteo.net> writes:
> 
> > xdg-desktop-portal (and xdg-desktop-portal-gnome) is needed for the
> > dark theme in Gnome 44 to work properly.
> > 
> > * gnu/packages/gnome.scm (gnome-essential-extras)[propagated-
> > inputs]: Add xdg-desktop-portal.
> > 
> > Change-Id: Id84626e6bc404e9607ee7f8f299ac90f24323081
> 
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
> 
> Haven't tested it myself, but I trust the findings of Dariqq.
The desktop portal seems like a harmless propagation, so I trust your
trust.

Pushed.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-04-06  4:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-31 18:05 bug#70111: Gnome 44: Dark Theme not Working Dariqq
2024-04-03  3:46 ` Maxim Cournoyer
2024-04-03  9:25 ` bug#70111: [PATCH] gnu: gnome-essential-extras: Propagate xdg-desktop-portal Dariqq
2024-04-03 18:11   ` Maxim Cournoyer
2024-04-06  4:50     ` Liliana Marie Prikler

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).