From: ludo@gnu.org (Ludovic Courtès)
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
Cc: 30710-done@debbugs.gnu.org,
Hartmut Goebel <h.goebel@crazy-compilers.com>
Subject: bug#30710: guix graph gives duplicate nodes
Date: Fri, 09 Mar 2018 23:59:26 +0100 [thread overview]
Message-ID: <87d10cyhwx.fsf@gnu.org> (raw)
In-Reply-To: <20180309110917.79b14a36@alma-ubu> ("Björn Höfling"'s message of "Fri, 9 Mar 2018 11:09:17 +0100")
Björn Höfling <bjoern.hoefling@bjoernhoefling.de> skribis:
> If you look into gnu/packages/autotools.scm, you see that
> autoconf-wrapper is not a package, but a package-factory:
>
> (define* (autoconf-wrapper #:optional (autoconf autoconf))
>
> Now the package definitions of "automake" and "libtool" each use the
> same fragment of code in their native-inputs, but a different "package"
> in the eq?-sense, although they basically want the same thing:
>
> `(("autoconf" ,(autoconf-wrapper))
>
> As ludo stated above: "Most of the time, there’s exactly one package
> object for each derivation; if not, that’s usually a bug."
>
> This looks to me like a bug.
>
> Correction:
>
> (define autoconf-wrapper-default (autoconf-wrapper))
>
> And then use this singular package as native-inputs to libtool and automake.
>
> Furthermore, when I search:
>
> find . -name "*.scm" -exec grep -H "autoconf-wrapper" "{}" ";" | less
>
> I find about 10 packages that use the fabrik, but all in the default way.
>
> So instead of:
>
> #:export (autoconf-wrapper))
>
>
> We could just
>
> (define-public autoconf-wrapper-default (autoconf-wrapper))
>
> and use that.
>
> Or, if noone is using this fabrik, just drop that and make a normal package out of it.
>
> WDYT? Reopen this one?
Good catch! I implemented what you suggest above in commit
464f5447396fcec9b43f7eab71d5d42b522a157f.
Thank you!
Ludo’.
next prev parent reply other threads:[~2018-03-09 23:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 9:37 bug#30710: guix graph gives duplicate nodes Hartmut Goebel
2018-03-05 17:19 ` Ludovic Courtès
2018-03-06 20:28 ` Hartmut Goebel
2018-03-07 15:18 ` Ludovic Courtès
2018-03-09 10:09 ` Björn Höfling
2018-03-09 22:59 ` Ludovic Courtès [this message]
[not found] ` <20180310111335.53c3bb1b@alma-ubu>
2018-03-10 16:31 ` Hartmut Goebel
2018-03-12 14:27 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d10cyhwx.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=30710-done@debbugs.gnu.org \
--cc=bjoern.hoefling@bjoernhoefling.de \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).