From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#30710: guix graph gives duplicate nodes
Date: Fri, 09 Mar 2018 23:59:26 +0100
Message-ID: <87d10cyhwx.fsf@gnu.org>
References: <86fb9895-768a-bea0-154c-070861c0bb1d@crazy-compilers.com>
	<87d10i8mpb.fsf@gnu.org>
	<c9c92f41-65ea-3ac8-daa8-2cc9b7fbddf5@crazy-compilers.com>
	<87efkvsylg.fsf@gnu.org> <20180309110917.79b14a36@alma-ubu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52979)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1euQze-0005lx-NZ
	for bug-guix@gnu.org; Fri, 09 Mar 2018 18:00:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1euQza-0000pm-Sl
	for bug-guix@gnu.org; Fri, 09 Mar 2018 18:00:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:45029)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1euQza-0000pi-P3
	for bug-guix@gnu.org; Fri, 09 Mar 2018 18:00:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1euQza-0006FW-BU
	for bug-guix@gnu.org; Fri, 09 Mar 2018 18:00:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.30710.D30710.152063637023951@debbugs.gnu.org>
In-Reply-To: <20180309110917.79b14a36@alma-ubu> ("=?UTF-8?Q?Bj=C3=B6rn_?=
	=?UTF-8?Q?H=C3=B6fling?="'s message of
	"Fri, 9 Mar 2018 11:09:17 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= <bjoern.hoefling@bjoernhoefling.de>
Cc: 30710-done@debbugs.gnu.org, Hartmut Goebel <h.goebel@crazy-compilers.com>

Bj=C3=B6rn H=C3=B6fling <bjoern.hoefling@bjoernhoefling.de> skribis:

> If you look into gnu/packages/autotools.scm, you see that
> autoconf-wrapper is not a package, but a package-factory:
>
> (define* (autoconf-wrapper #:optional (autoconf autoconf))
>
> Now the package definitions of "automake" and "libtool" each use the
> same fragment of code in their native-inputs, but a different "package"
> in the eq?-sense, although they basically want the same thing:
>
>  `(("autoconf" ,(autoconf-wrapper))
>
> As ludo stated above: "Most of the time, there=E2=80=99s exactly one pack=
age
> object for each derivation; if not, that=E2=80=99s usually a bug."
>
> This looks to me like a bug.
>
> Correction:
>
> (define autoconf-wrapper-default (autoconf-wrapper))
>
> And then use this singular package as native-inputs to libtool and automa=
ke.
>
> Furthermore, when I search:
>
> find . -name "*.scm" -exec grep -H "autoconf-wrapper" "{}" ";" | less
>
> I find about 10 packages that use the fabrik, but all in the default way.
>
> So instead of:
>
>   #:export (autoconf-wrapper))
>
>
> We could just=20
>
> (define-public autoconf-wrapper-default (autoconf-wrapper))
>
> and use that.
>
> Or, if noone is using this fabrik, just drop that and make a normal packa=
ge out of it.
>
> WDYT? Reopen this one?

Good catch!  I implemented what you suggest above in commit
464f5447396fcec9b43f7eab71d5d42b522a157f.

Thank you!

Ludo=E2=80=99.