unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Marius Bakke <marius@gnu.org>
Cc: pkill9 <pkill9@runbox.com>, 42420@debbugs.gnu.org
Subject: bug#42420: git-fetch origins produce same store output when set recursive is set to true or false
Date: Sat, 28 Nov 2020 00:23:28 -0500	[thread overview]
Message-ID: <87czzynjfz.fsf@gmail.com> (raw)
In-Reply-To: <878sf7vct2.fsf@gnu.org> (Marius Bakke's message of "Sat, 25 Jul 2020 17:23:21 +0200")

Hello,

Marius Bakke <marius@gnu.org> writes:

> pkill9 <pkill9@runbox.com> writes:
>
>> I built a source that uses git-fetch - by default (recursive? #f) - and
>> the package failed to build, then I remembered it uses submodules, so I
>> set (recursive? #t) but it failed with the same error. The problem is
>> that the store path of the source is the same for both, so it didn't
>> try to rebuild the git checkout with submodules checked out.
>>
>> After garbage collecting the source so it rebuilds it, I can build the
>> package.
>
> Could it be that you did not update the sha256 checksum of the package
> after setting (recursive? #t), so Guix thought it already had the
> complete checkout in the store?

Yes, that just happened to me.  It's confusing, but I don't see how we
can improve on that. pkill, next time this happens, you might want to
force a check on the cached source via 'guix build --source --check'.  I
believe this would flag the discrepancy.

Is there an action to do here, or should we simply close it?

Thanks,

Maxim




  reply	other threads:[~2020-11-28  5:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-18 22:19 bug#42420: git-fetch origins produce same store output when set recursive is set to true or false pkill9
2020-07-25 15:23 ` Marius Bakke
2020-11-28  5:23   ` Maxim Cournoyer [this message]
2020-11-28 17:04     ` Leo Famulari
2020-11-30  4:06       ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czzynjfz.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=42420@debbugs.gnu.org \
    --cc=marius@gnu.org \
    --cc=pkill9@runbox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).