From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4HWoJAzfwV+PHQAA0tVLHw (envelope-from ) for ; Sat, 28 Nov 2020 05:24:28 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id lUFhIAzfwV/FUQAAB5/wlQ (envelope-from ) for ; Sat, 28 Nov 2020 05:24:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 045A794043A for ; Sat, 28 Nov 2020 05:24:28 +0000 (UTC) Received: from localhost ([::1]:46122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kisif-0002J5-VG for larch@yhetil.org; Sat, 28 Nov 2020 00:24:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kisiI-0002It-GI for bug-guix@gnu.org; Sat, 28 Nov 2020 00:24:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kisiI-00077l-7v for bug-guix@gnu.org; Sat, 28 Nov 2020 00:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kisiI-0003cN-4F for bug-guix@gnu.org; Sat, 28 Nov 2020 00:24:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#42420: git-fetch origins produce same store output when set recursive is set to true or false Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 28 Nov 2020 05:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42420 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Marius Bakke Received: via spool by 42420-submit@debbugs.gnu.org id=B42420.160654101913878 (code B ref 42420); Sat, 28 Nov 2020 05:24:02 +0000 Received: (at 42420) by debbugs.gnu.org; 28 Nov 2020 05:23:39 +0000 Received: from localhost ([127.0.0.1]:46828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kishv-0003bm-40 for submit@debbugs.gnu.org; Sat, 28 Nov 2020 00:23:39 -0500 Received: from mail-qk1-f179.google.com ([209.85.222.179]:33241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kisht-0003bW-BF for 42420@debbugs.gnu.org; Sat, 28 Nov 2020 00:23:37 -0500 Received: by mail-qk1-f179.google.com with SMTP id 1so4868937qka.0 for <42420@debbugs.gnu.org>; Fri, 27 Nov 2020 21:23:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PSaBAfE98mAGgvdM/32M7QYMpqSwB8hvjrYZ/8Wv070=; b=u76okleF8vmtlgnpeNa8QgfGZLKLPjZUSBoyXr/EGnalJnbNwyodNrVivSLZytC6n1 BgiVkLzw50aXKOnFde6BKYWVtfBNWKWzRjdsUGZoITxCLn3BbHsZ2q9pthcdp10s9r3q Rwx2ajnxQVYBPUP3J3mjLWghK6oCRsvvfiLtx6AGvIQDqyyzgKBmw04E0EVqSj/k3m4f wr9NL13B7gsGT/RnqX9Ho7c4KHqO1uFq0/YT8bevjv2kPv/hKBHk/NvfsJkEtq//8ltT +o7S5nv9KAAmFoG0gCMmBJkAfR8TZ+cxxw8WfS7iHZdgmm10f/LecrGEtYSbjGyOoE9b qKhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PSaBAfE98mAGgvdM/32M7QYMpqSwB8hvjrYZ/8Wv070=; b=Z0nDG1gPLZ3dvNl8oCNxFh3FCSfyo7sK1P++A3LFAYih3hjaoYIv3ggJM7y4xYqsuT hyKZ5Ri/rRN2y7+Mx9UOxPJrKQZ0udGNIy3C0pKcx/Cnkgb1q698lRaTCa4LG6aThCyi OSde0qB1rJrbf3+hH5+AsRZ5BDspdWnlmCuBE0hrNXMBGSFp56nf1dVwOg+JvP/XAMM/ mOab1rYaEnnn60V2VNxGDRMxKmnAayoSaYfjHotdJ56yovp8gbdtHYsJGWh9KJnh0kXn Igfe+ROqvqXTBGZem/V5sJLjh2m1LJgSluwJowFymHC4RR+eXNtX2WMZOimSkARh79DN t/7A== X-Gm-Message-State: AOAM531qNnT+F6vsm5GukC+m2WpTQAJxcvu/JGyuQPUV4mKhTdZxbuKi BXoi72jc5vSxbcJ/pIX04jnzlo0atcSj1A== X-Google-Smtp-Source: ABdhPJzJbvYarmxT3dqcFrvDu1Jud8rC0DrsazVym8H5nhyFHSlJ9lk902+svTMthTWUq+dTAIxNWA== X-Received: by 2002:a37:ac19:: with SMTP id e25mr11649889qkm.344.1606541010636; Fri, 27 Nov 2020 21:23:30 -0800 (PST) Received: from hurd (dsl-205-151-56-74.b2b2c.ca. [205.151.56.74]) by smtp.gmail.com with ESMTPSA id l79sm8701335qke.1.2020.11.27.21.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 21:23:29 -0800 (PST) From: Maxim Cournoyer References: <20200718231909.646cbf7d@runbox.com> <878sf7vct2.fsf@gnu.org> Date: Sat, 28 Nov 2020 00:23:28 -0500 In-Reply-To: <878sf7vct2.fsf@gnu.org> (Marius Bakke's message of "Sat, 25 Jul 2020 17:23:21 +0200") Message-ID: <87czzynjfz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pkill9 , 42420@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.17 X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=u76okleF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-TUID: bDeuYNwjws9O Hello, Marius Bakke writes: > pkill9 writes: > >> I built a source that uses git-fetch - by default (recursive? #f) - and >> the package failed to build, then I remembered it uses submodules, so I >> set (recursive? #t) but it failed with the same error. The problem is >> that the store path of the source is the same for both, so it didn't >> try to rebuild the git checkout with submodules checked out. >> >> After garbage collecting the source so it rebuilds it, I can build the >> package. > > Could it be that you did not update the sha256 checksum of the package > after setting (recursive? #t), so Guix thought it already had the > complete checkout in the store? Yes, that just happened to me. It's confusing, but I don't see how we can improve on that. pkill, next time this happens, you might want to force a check on the cached source via 'guix build --source --check'. I believe this would flag the discrepancy. Is there an action to do here, or should we simply close it? Thanks, Maxim