* bug#56343: ‘tests/services/telephony.scm’ fails to run
@ 2022-07-01 21:34 Ludovic Courtès
2022-07-02 7:35 ` Maxim Cournoyer
2022-07-07 14:45 ` Maxim Cournoyer
0 siblings, 2 replies; 5+ messages in thread
From: Ludovic Courtès @ 2022-07-01 21:34 UTC (permalink / raw)
To: 56343; +Cc: Maxim Cournoyer
Hi,
The ‘tests/services/telephony.scm’ file exercises procedures that were
removed from (gnu build jami-service) in
85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
from proceeding:
--8<---------------cut here---------------start------------->8---
$ make check -j5
[...]
PASS: tests/services/file-sharing.scm
PASS: tests/services.scm
PASS: tests/services/linux.scm
make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
make[4]: *** Waiting for unfinished jobs....
PASS: tests/sets.scm
PASS: tests/packages.scm
PASS: tests/pack.scm
PASS: tests/lint.scm
make[4]: Leaving directory '/home/ludo/src/guix'
make[3]: *** [Makefile:6061: check-TESTS] Error 2
--8<---------------cut here---------------end--------------->8---
Should we keep some of the tests in this file, or has it become obsolete
entirely?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#56343: ‘tests/services/telephony.scm’ fails to run
2022-07-01 21:34 bug#56343: ‘tests/services/telephony.scm’ fails to run Ludovic Courtès
@ 2022-07-02 7:35 ` Maxim Cournoyer
2022-07-05 9:27 ` Lars-Dominik Braun
2022-07-07 14:45 ` Maxim Cournoyer
1 sibling, 1 reply; 5+ messages in thread
From: Maxim Cournoyer @ 2022-07-02 7:35 UTC (permalink / raw)
To: 56343, ludo
On July 1, 2022 5:34:37 PM EDT, "Ludovic Courtès" <ludo@gnu.org> wrote:
>Hi,
>
>The ‘tests/services/telephony.scm’ file exercises procedures that were
>removed from (gnu build jami-service) in
>85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
>from proceeding:
>
>--8<---------------cut here---------------start------------->8---
>$ make check -j5
>
>[...]
>
>PASS: tests/services/file-sharing.scm
>PASS: tests/services.scm
>PASS: tests/services/linux.scm
>make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
>make[4]: *** Waiting for unfinished jobs....
>PASS: tests/sets.scm
>PASS: tests/packages.scm
>PASS: tests/pack.scm
>PASS: tests/lint.scm
>make[4]: Leaving directory '/home/ludo/src/guix'
>make[3]: *** [Makefile:6061: check-TESTS] Error 2
>--8<---------------cut here---------------end--------------->8---
>
>Should we keep some of the tests in this file, or has it become obsolete
>entirely?
It isn't obsolete, but I had forgotten there were both unit and functional (system) tests for our Jami seevice. It's probably easy to adjust, I can look into it when I'm back from travels in a few days.
Cheers,
Maxim
Hi,
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#56343: ‘tests/services/telephony.scm’ fails to run
2022-07-02 7:35 ` Maxim Cournoyer
@ 2022-07-05 9:27 ` Lars-Dominik Braun
0 siblings, 0 replies; 5+ messages in thread
From: Lars-Dominik Braun @ 2022-07-05 9:27 UTC (permalink / raw)
To: Maxim Cournoyer; +Cc: 56343, Ludovic Courtès
Hi Maxim,
> It isn't obsolete, but I had forgotten there were both unit and functional (system) tests for our Jami seevice. It's probably easy to adjust, I can look into it when I'm back from travels in a few days.
I had to remove tests/services/telephony.scm from Makefile.am, so
we could update the guix package to fix other issues. Please revert
c23e0aa65d511a29f31da876f905594c0f8bce00 once you’ve fixed the tests.
Thanks,
Lars
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#56343: ‘tests/services/telephony.scm’ fails to run
2022-07-01 21:34 bug#56343: ‘tests/services/telephony.scm’ fails to run Ludovic Courtès
2022-07-02 7:35 ` Maxim Cournoyer
@ 2022-07-07 14:45 ` Maxim Cournoyer
2022-07-08 8:38 ` Ludovic Courtès
1 sibling, 1 reply; 5+ messages in thread
From: Maxim Cournoyer @ 2022-07-07 14:45 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 56343-done
Hi,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi,
>
> The ‘tests/services/telephony.scm’ file exercises procedures that were
> removed from (gnu build jami-service) in
> 85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
> from proceeding:
>
> $ make check -j5
>
> [...]
>
> PASS: tests/services/file-sharing.scm
> PASS: tests/services.scm
> PASS: tests/services/linux.scm
> make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
> make[4]: *** Waiting for unfinished jobs....
> PASS: tests/sets.scm
> PASS: tests/packages.scm
> PASS: tests/pack.scm
> PASS: tests/lint.scm
> make[4]: Leaving directory '/home/ludo/src/guix'
> make[3]: *** [Makefile:6061: check-TESTS] Error 2
>
> Should we keep some of the tests in this file, or has it become obsolete
> entirely?
I've remove all the parsing tests and kept the others; see
258bc4c4e668e9817471d04d052bc0a8e2d43fa0.
Thanks for the heads-up!
Closing.
Maxim
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-08 8:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-01 21:34 bug#56343: ‘tests/services/telephony.scm’ fails to run Ludovic Courtès
2022-07-02 7:35 ` Maxim Cournoyer
2022-07-05 9:27 ` Lars-Dominik Braun
2022-07-07 14:45 ` Maxim Cournoyer
2022-07-08 8:38 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).