unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#60688: guix: home: environment-variables: Breaking change 73684dc90
@ 2023-01-09  0:27 Kabelo Moiloa via Bug reports for GNU Guix
  2023-01-09  9:11 ` Andrew Tropin
  0 siblings, 1 reply; 2+ messages in thread
From: Kabelo Moiloa via Bug reports for GNU Guix @ 2023-01-09  0:27 UTC (permalink / raw)
  To: 60688

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Before this commit it was possible to build a guix home configuration where home-environment-variables-service-type could ungexp any file-like object such as a package. The commit 73684dc90 forces it to be a string, which contradicts the documentation for guix. 

Concretely, guix home environment test-home.scm worked before that commit where test-home.scm is attached to this email.

-- 
 Regards,
Kabelo M'sobomvu Moiloa

[-- Attachment #2: test-home.scm --]
[-- Type: text/x-scheme, Size: 360 bytes --]

(use-modules (guix gexp)
             (gnu home)
             (gnu home services)
             (gnu packages base)
             (gnu services))

(home-environment
 (services
  (list
   (simple-service 'add-environment-variable
                   home-environment-variables-service-type
                   `(("PACKAGE" . ,(file-append hello "/bin/hello")))))))

^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#60688: guix: home: environment-variables: Breaking change 73684dc90
  2023-01-09  0:27 bug#60688: guix: home: environment-variables: Breaking change 73684dc90 Kabelo Moiloa via Bug reports for GNU Guix
@ 2023-01-09  9:11 ` Andrew Tropin
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Tropin @ 2023-01-09  9:11 UTC (permalink / raw)
  To: 60688, Kabelo Moiloa

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

yhetil mirror is a little behind and I've not received this email thread
yet and thus it's not in my guix-home notmuch search.  A few minutes ago
I saw you forwarded this thread to me and patches look good, but I
already made and pushed similiar changes.  Sorry for inconvenience.

-- 
Best regards,
Andrew Tropin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-09 19:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-09  0:27 bug#60688: guix: home: environment-variables: Breaking change 73684dc90 Kabelo Moiloa via Bug reports for GNU Guix
2023-01-09  9:11 ` Andrew Tropin

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).