bug#32820: Some CSS not displaying in latest Icecat

bug#32820: Some CSS not displaying in latest Icecat

[Christopher Lemmer Webber]

Overall very excited about the new Icecat being available!

However, css is not displaying on some sites, and I'm not sure why.
Disable all extensions and try the following examples:

  https://addons.mozilla.org/en-US/firefox/
  https://github.com/

Both will show up unstyled.  Not sure the cause; Firefox's developer
console doesn't seem to indicate anything relevant.

bug#32820: Some CSS not displaying in latest Icecat

[Ricardo Wurmus]

Christopher Lemmer Webber <cwebber@dustycloud.org> writes:

> Overall very excited about the new Icecat being available!
>
> However, css is not displaying on some sites, and I'm not sure why.
> Disable all extensions and try the following examples:
>
>   https://addons.mozilla.org/en-US/firefox/
>   https://github.com/
>
> Both will show up unstyled.  Not sure the cause; Firefox's developer
> console doesn't seem to indicate anything relevant.

This is really weird.

Open the developer console and switch to the Style Editor tab.  On
github.com you’ll see a bunch of CSS files with a note under each saying
“0 rules”.  To the right you see the CSS sources.  Now add a space
character (or make some other edit in the source pane): all of a sudden
the CSS file can be parsed!

When you do this to each file, Icecat is going to render the page just
fine.

I also note that Icecat tells me that the page is not encrypted, despite
visiting the https site without errors.  Something’s not quite right
here.

--
Ricardo

bug#32820: Some CSS not displaying in latest Icecat

[Mark H Weaver]

Hi Chris,

Christopher Lemmer Webber <cwebber@dustycloud.org> writes:

> Overall very excited about the new Icecat being available!
>
> However, css is not displaying on some sites, and I'm not sure why.
> Disable all extensions and try the following examples:
>
>   https://addons.mozilla.org/en-US/firefox/
>   https://github.com/
>
> Both will show up unstyled.

Indeed, I see the same problem.  My first guess is that it's related to
the fact that we aren't (yet) using Servo, Mozilla's new CSS engine.
Servo requires LLVM/Clang to build, so I disabled it for now, to
simplify the task of getting IceCat 60 working.

I'll work on enabling Servo in our IceCat package, and see if that fixes
the problem.

Thanks for the report!

      Mark

bug#32820: Some CSS not displaying in latest Icecat

[Mike Gerwitz]

[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]

On Mon, Sep 24, 2018 at 23:21:08 -0400, Mark H Weaver wrote:

[...]

> Christopher Lemmer Webber <cwebber@dustycloud.org> writes:
>
>> Overall very excited about the new Icecat being available!
>>
>> However, css is not displaying on some sites, and I'm not sure why.
>> Disable all extensions and try the following examples:
>>
>>   https://addons.mozilla.org/en-US/firefox/
>>   https://github.com/
>>
>> Both will show up unstyled.

I was about to report the same, for exactly those sites (just upgraded
Icecat about an hour ago).

> Indeed, I see the same problem.  My first guess is that it's related to
> the fact that we aren't (yet) using Servo, Mozilla's new CSS engine.
> Servo requires LLVM/Clang to build, so I disabled it for now, to
> simplify the task of getting IceCat 60 working.
>
> I'll work on enabling Servo in our IceCat package, and see if that fixes
> the problem.

Thanks!

I tried to do more digging to figure out what may be going on, but it's
late and I haven't had any luck.  The error still happens in safe mode,
and it's unrelated to CSP (the CSS does actually load, and is even
visible in the Style Editor, but isn't rendered).  Icecat isn't
providing any errors anywhere, and I didn't find anything useful in
strace output.

So hopefully enabling Servo fixes it!  I'm curious to know why these
pages work but not others.

-- 
Mike Gerwitz
Free Software Hacker+Activist | GNU Maintainer & Volunteer
GPG: D6E9 B930 028A 6C38 F43B  2388 FEF6 3574 5E6F 6D05
https://mikegerwitz.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

bug#32820: Some CSS not displaying in latest Icecat

[Mark H Weaver]

Hi,

Christopher Lemmer Webber <cwebber@dustycloud.org> writes:

> Disable all extensions and try the following examples:
>
>   https://addons.mozilla.org/en-US/firefox/
>   https://github.com/
>
> Both will show up unstyled.

I just pushed some changes to our IceCat package which I didn't expect
to affect this issue, namely:

  * 6d3288793..: Mark H Weaver 2018-09-25 gnu: icecat: Rebundle NSPR and NSS [security fix].
  * 94e96f7f6..: Mark H Weaver 2018-09-24 gnu: icecat: Unbundle libevent, libogg, and libvorbis.
  * 257e32479..: Mark H Weaver 2018-09-23 gnu: icecat: Unbundle graphite2 and harfbuzz.

However, as of commit 6d328879378fac95240005233331f596fb5c68ed on the
master branch, I can no longer reproduce this problem.  The two pages
above are both properly styled for me now.

When you get a chance, can you try the new version and report back?

      Mark

bug#32820: Some CSS not displaying in latest Icecat

[Mike Gerwitz]

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

On Tue, Sep 25, 2018 at 20:22:12 -0400, Mark H Weaver wrote:
> I just pushed some changes to our IceCat package which I didn't expect
> to affect this issue, namely:
>
>   * 6d3288793..: Mark H Weaver 2018-09-25 gnu: icecat: Rebundle NSPR and NSS [security fix].
>   * 94e96f7f6..: Mark H Weaver 2018-09-24 gnu: icecat: Unbundle libevent, libogg, and libvorbis.
>   * 257e32479..: Mark H Weaver 2018-09-23 gnu: icecat: Unbundle graphite2 and harfbuzz.
>
> However, as of commit 6d328879378fac95240005233331f596fb5c68ed on the
> master branch, I can no longer reproduce this problem.  The two pages
> above are both properly styled for me now.
>
> When you get a chance, can you try the new version and report back?

I also verified that those pages render correctly using IceCat's alpha
binary on a Debian system.  I'll build overnight and let you know
tomorrow if the CSS issues are resolved for me.

Thanks for the quick response on this!

-- 
Mike Gerwitz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

bug#32820: Some CSS not displaying in latest Icecat

[Mike Gerwitz]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

>> When you get a chance, can you try the new version and report back?
>
> I also verified that those pages render correctly using IceCat's alpha
> binary on a Debian system.  I'll build overnight and let you know
> tomorrow if the CSS issues are resolved for me.

LGTM!

-- 
Mike Gerwitz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

bug#32820: Some CSS not displaying in latest Icecat

[Christopher Lemmer Webber]

Mike Gerwitz writes:

>>> When you get a chance, can you try the new version and report back?
>>
>> I also verified that those pages render correctly using IceCat's alpha
>> binary on a Debian system.  I'll build overnight and let you know
>> tomorrow if the CSS issues are resolved for me.
>
> LGTM!

Works great for me too!  Closing this.

bug#32820: Some CSS not displaying in latest Icecat

[Christopher Lemmer Webber]

Oh, and thank you for your impressive work as usual Mark... we all
appreciate it :)

bug#32820: Some CSS not displaying in latest Icecat

[Mike Gerwitz]

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

On Mon, Sep 24, 2018 at 23:05:17 +0200, Ricardo Wurmus wrote:
> Open the developer console and switch to the Style Editor tab.  On
> github.com you’ll see a bunch of CSS files with a note under each saying
> “0 rules”.  To the right you see the CSS sources.  Now add a space
> character (or make some other edit in the source pane): all of a sudden
> the CSS file can be parsed!
>
> When you do this to each file, Icecat is going to render the page just
> fine.

That's an interesting find!

Fortunately, since Mark's changes, I haven't experienced any further
issues.  But it's bizarre indeed.

> I also note that Icecat tells me that the page is not encrypted, despite
> visiting the https site without errors.  Something’s not quite right
> here.

Mark fixed this in 32833 (<87a7o5cdv3.fsf@netris.org>).

-- 
Mike Gerwitz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]