unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Carlo Zancanaro <carlo@zancanaro.id.au>
Cc: Ricardo Wurmus <rekado@elephly.net>, 31719@debbugs.gnu.org
Subject: bug#31719: icedtea-3 binaries contain references to icedtea-2
Date: Tue, 20 Apr 2021 18:38:56 +0200	[thread overview]
Message-ID: <87bla8c3mn.fsf@gnu.org> (raw)
In-Reply-To: <87tuo18a4l.fsf@zancanaro.id.au> (Carlo Zancanaro's message of "Tue, 20 Apr 2021 21:32:10 +1000")

Hi Carlo,

Carlo Zancanaro <carlo@zancanaro.id.au> skribis:

> From 60101b27543b7cc41a052d5bec95234ea4977d35 Mon Sep 17 00:00:00 2001
> From: Carlo Zancanaro <carlo@zancanaro.id.au>
> Date: Tue, 20 Apr 2021 21:22:20 +1000
> Subject: [PATCH] gnu: Fix openjdk library substitution when libraries aren't
>  found
>
> * gnu/packages/java.scm (icedtea-8, openjdk9, openjdk11): Fix JNI library
> substitution to not substitute #f if the library can't be found.

Thanks for the update patch!  Please mention ‘find-library’ in the
commit log, for clarity.

I think you can go and push it to master given that OpenJDK is probably
broken due to those #f right now.  However, please push an additional
commit at the same time that adds those #:disallowed-references I
proposed.  (Though you’ll have to rebuild openjdk@11 to be sure.)

Sounds good?

Ludo’.




  reply	other threads:[~2021-04-20 16:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 10:47 bug#31719: icedtea-3 binaries contain references to icedtea-2 Ricardo Wurmus
2018-06-05 11:49 ` Gábor Boskovits
2018-06-05 12:36   ` Ricardo Wurmus
2018-06-05 12:45   ` Leo Famulari
2018-06-05 14:45     ` Gábor Boskovits
2018-09-10 21:00 ` Gábor Boskovits
2020-05-14 18:02 ` Ricardo Wurmus
2021-02-27 11:17 ` bug#31719: Chains of dependencies getting longer Andreas Enge
2021-03-01 10:04   ` Ludovic Courtès
2021-03-01 12:00     ` Andreas Enge
2021-03-01 21:33       ` Ludovic Courtès
2021-03-01 22:15         ` Björn Höfling
2021-04-14  7:36           ` Ricardo Wurmus
2021-04-16 19:22             ` Björn Höfling
2021-04-16 22:26               ` Carlo Zancanaro
2021-04-17  7:11                 ` Carlo Zancanaro
2021-04-17  9:38                   ` Carlo Zancanaro
2021-04-19 16:22                     ` Andreas Enge
2021-04-19 18:18                       ` Ricardo Wurmus
2021-04-20  8:34                         ` Andreas Enge
2021-04-20  9:24                           ` bug#31719: icedtea-3 binaries contain references to icedtea-2 Ludovic Courtès
2021-04-20  9:36                             ` Andreas Enge
2021-04-20 11:32                             ` Carlo Zancanaro
2021-04-20 16:38                               ` Ludovic Courtès [this message]
2021-04-20 21:00                                 ` Carlo Zancanaro
2021-04-21 12:40                                   ` Ludovic Courtès
2021-04-20  9:01                         ` bug#31719: Chains of dependencies getting longer Carlo Zancanaro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bla8c3mn.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=31719@debbugs.gnu.org \
    --cc=carlo@zancanaro.id.au \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).