* bug#49916: etc/committer: backtrace on gexp
@ 2021-08-06 19:18 Sarah Morgensen
2021-08-07 10:25 ` Maxime Devos
0 siblings, 1 reply; 3+ messages in thread
From: Sarah Morgensen @ 2021-08-06 19:18 UTC (permalink / raw)
To: 49916; +Cc: Ricardo Wurmus
Hello Guix,
(Ricardo, I've Cc'd you since it seems etc/committer.scm is mostly your
work.)
It looks like etc/committer.scm is choking on gexps on core-updates-frozen:
--8<---------------cut here---------------start------------->8---
~/guix-cu-frozen [env]$ etc/committer.scm
ice-9/read.scm:126:4: In procedure read-expr*:
gnu/packages/games.scm:13005:11: Unknown # object: "#~"
--8<---------------cut here---------------end--------------->8---
...and this is the offending package:
--8<---------------cut here---------------start------------->8---
(define-public 0ad-data
(package
(name "0ad-data")
(version "0.0.23b-alpha")
(source
(origin
(method url-fetch)
(uri (string-append "https://releases.wildfiregames.com/0ad-"
version "-unix-data.tar.xz"))
(file-name (string-append name "-" version ".tar.xz"))
(sha256
(base32
"04x7729hk6zw1xj3n4s4lvaviijsnbjf5rhzvjxlr5fygvg4l6z1"))
(modules '((guix build utils)))
(snippet
#~(begin
(for-each (lambda (name)
(let* ((dir (string-append "binaries/data/mods/" name))
(file (string-append dir "/" name ".zip"))
(unzip #$(file-append unzip "/bin/unzip")))
(invoke unzip "-d" dir file)
(delete-file file)))
'("mod" "public"))
#t))))
(build-system trivial-build-system)
--8<---------------cut here---------------end--------------->8---
I think with the changes from new style inputs, gexps in packages are
going to become more common, so etc/committer.scm should support them.
WDYT?
--
Sarah
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#49916: etc/committer: backtrace on gexp
2021-08-06 19:18 bug#49916: etc/committer: backtrace on gexp Sarah Morgensen
@ 2021-08-07 10:25 ` Maxime Devos
2021-08-07 12:06 ` Ricardo Wurmus
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Devos @ 2021-08-07 10:25 UTC (permalink / raw)
To: Sarah Morgensen, 49916; +Cc: Ricardo Wurmus
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
Sarah Morgensen schreef op vr 06-08-2021 om 12:18 [-0700]:
> Hello Guix,
>
> (Ricardo, I've Cc'd you since it seems etc/committer.scm is mostly your
> work.)
>
> It looks like etc/committer.scm is choking on gexps on core-updates-frozen:
> [...]
The patch <http://issues.guix.gnu.org/48120#3> should fix this.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#49916: etc/committer: backtrace on gexp
2021-08-07 10:25 ` Maxime Devos
@ 2021-08-07 12:06 ` Ricardo Wurmus
0 siblings, 0 replies; 3+ messages in thread
From: Ricardo Wurmus @ 2021-08-07 12:06 UTC (permalink / raw)
To: Maxime Devos; +Cc: 49916-done, Sarah Morgensen
Maxime Devos <maximedevos@telenet.be> writes:
> Sarah Morgensen schreef op vr 06-08-2021 om 12:18 [-0700]:
>> Hello Guix,
>>
>> (Ricardo, I've Cc'd you since it seems etc/committer.scm is
>> mostly your
>> work.)
>>
>> It looks like etc/committer.scm is choking on gexps on
>> core-updates-frozen:
>> [...]
>
> The patch <http://issues.guix.gnu.org/48120#3> should fix this.
I’ve just pushed that one. Thank you!
--
Ricardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-07 12:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06 19:18 bug#49916: etc/committer: backtrace on gexp Sarah Morgensen
2021-08-07 10:25 ` Maxime Devos
2021-08-07 12:06 ` Ricardo Wurmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).