unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Damien Cassou <damien@cassou.me>
To: 39969@debbugs.gnu.org
Subject: bug#39969: Inconsistent specification of a file-system's device
Date: Sat, 07 Mar 2020 10:05:40 +0100	[thread overview]
Message-ID: <87a74sk00r.fsf@cassou.me> (raw)

Hi,

the manual says that file system labels should be specified with the
file-system-label procedure like this:

    (file-system
      (mount-point "/home")
      (type "ext4")
      (device (file-system-label "my-home")))


Nevertheless, system-qemu-image seems to expect only strings:

    (define* (system-qemu-image os
                                #:key
                                (file-system-type "ext4")
                                (disk-image-size (* 900 (expt 2 20))))
      (define file-systems-to-keep
        ;; Keep only file systems other than root and not normally bound to real
        ;; devices.
        (remove (lambda (fs)
                  (let ((target (file-system-mount-point fs))
                        (source (file-system-device fs)))
                    (or (string=? target "/")
                        (string-prefix? "/dev/" source))))
                (operating-system-file-systems os)))


The code above stores the result of file-system-device to the source
variable and then expects it to be a string.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

                 reply	other threads:[~2020-03-07  9:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a74sk00r.fsf@cassou.me \
    --to=damien@cassou.me \
    --cc=39969@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).