From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Cassou Subject: bug#39969: Inconsistent specification of a file-system's device Date: Sat, 07 Mar 2020 10:05:40 +0100 Message-ID: <87a74sk00r.fsf@cassou.me> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:37755) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAVPH-0008C5-VV for bug-guix@gnu.org; Sat, 07 Mar 2020 04:06:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAVPG-0004rg-RX for bug-guix@gnu.org; Sat, 07 Mar 2020 04:06:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40278) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jAVPG-0004rR-OB for bug-guix@gnu.org; Sat, 07 Mar 2020 04:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jAVPG-0002vm-Hq for bug-guix@gnu.org; Sat, 07 Mar 2020 04:06:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:37607) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAVP1-00088M-4R for bug-guix@gnu.org; Sat, 07 Mar 2020 04:05:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAVP0-0004Ij-4m for bug-guix@gnu.org; Sat, 07 Mar 2020 04:05:47 -0500 Received: from mail.choca.pics ([80.67.172.235]:33152) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jAVOz-0004B5-V4 for bug-guix@gnu.org; Sat, 07 Mar 2020 04:05:46 -0500 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 0ED6F181929EE for ; Sat, 7 Mar 2020 10:05:42 +0100 (CET) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id dBH7bvYSaekR for ; Sat, 7 Mar 2020 10:05:41 +0100 (CET) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 8FCAA181929E8 for ; Sat, 7 Mar 2020 10:05:41 +0100 (CET) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id LKLolgRnFzZA for ; Sat, 7 Mar 2020 10:05:41 +0100 (CET) Received: from luz4 (176-140-37-135.abo.bbox.fr [176.140.37.135]) by mail.choca.pics (Postfix) with ESMTPSA id 3DC7118192B26 for ; Sat, 7 Mar 2020 10:05:41 +0100 (CET) List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: 39969@debbugs.gnu.org Hi, the manual says that file system labels should be specified with the file-system-label procedure like this: (file-system (mount-point "/home") (type "ext4") (device (file-system-label "my-home"))) Nevertheless, system-qemu-image seems to expect only strings: (define* (system-qemu-image os #:key (file-system-type "ext4") (disk-image-size (* 900 (expt 2 20)))) (define file-systems-to-keep ;; Keep only file systems other than root and not normally bound to real ;; devices. (remove (lambda (fs) (let ((target (file-system-mount-point fs)) (source (file-system-device fs))) (or (string=? target "/") (string-prefix? "/dev/" source)))) (operating-system-file-systems os))) The code above stores the result of file-system-device to the source variable and then expects it to be a string. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill