unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Lemmer Webber <cwebber@dustycloud.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 42158-done@debbugs.gnu.org
Subject: bug#42158: python-grequests broken, add zope dependencies to fix.
Date: Thu, 02 Jul 2020 08:16:37 -0400	[thread overview]
Message-ID: <87a70iyuvu.fsf@dustycloud.org> (raw)
In-Reply-To: <20200702072733.GF6387@E5400>

Efraim Flashner writes:

> On Wed, Jul 01, 2020 at 04:39:05PM -0400, Christopher Lemmer Webber wrote:
>> Fix attached.  Ok to push?
>> 
>
> Looks good to me. I will note however that the test suite doesn't seem
> to actually be run.

Huh.  Well at least it's no longer breaking, which is what was happening
for me before.

>> From 1fc31863857361e9f88d92cbea2099fd7ea03b10 Mon Sep 17 00:00:00 2001
>> From: Christopher Lemmer Webber <cwebber@dustycloud.org>
>> Date: Wed, 1 Jul 2020 16:36:29 -0400
>> Subject: [PATCH] gnu: python-grequests: Fix tests by adding zope dependencies.
>> 
>> * gnu/packages/python-web.scm (python-grequests): Add zope
>>   dependencies to native-inputs for tests.
>
> should be:
>
> * gnu/packages/python-web.scm (python-grequests)[native-inputs]:
> Add python-zope.interface, python-zope.event.
>

Done.  Changed and pushed!

>> ---
>>  gnu/packages/python-web.scm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
>> index 030abef9c2..c929e254f7 100644
>> --- a/gnu/packages/python-web.scm
>> +++ b/gnu/packages/python-web.scm
>> @@ -2010,7 +2010,9 @@ library.")
>>       `(("python-gevent" ,python-gevent)
>>         ("python-requests" ,python-requests)))
>>      (native-inputs
>> -     `(("python-nose" ,python-nose)))
>> +     `(("python-nose" ,python-nose)
>> +       ("python-zope.interface" ,python-zope-interface)
>> +       ("python-zope.event" ,python-zope-event)))
>>      (home-page "https://github.com/kennethreitz/grequests")
>>      (synopsis "Python library for asynchronous HTTP requests")
>>      (description "GRequests is a Python library that allows you to use
>> -- 
>> 2.26.2
>> 





      reply	other threads:[~2020-07-02 12:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 20:39 bug#42158: python-grequests broken, add zope dependencies to fix Christopher Lemmer Webber
2020-07-02  7:27 ` Efraim Flashner
2020-07-02 12:16   ` Christopher Lemmer Webber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a70iyuvu.fsf@dustycloud.org \
    --to=cwebber@dustycloud.org \
    --cc=42158-done@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).