unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Christopher Lemmer Webber <cwebber@dustycloud.org>
Cc: 42158@debbugs.gnu.org
Subject: bug#42158: python-grequests broken, add zope dependencies to fix.
Date: Thu, 2 Jul 2020 10:27:33 +0300	[thread overview]
Message-ID: <20200702072733.GF6387@E5400> (raw)
In-Reply-To: <87zh8jynpy.fsf@dustycloud.org>

[-- Attachment #1: Type: text/plain, Size: 1789 bytes --]

On Wed, Jul 01, 2020 at 04:39:05PM -0400, Christopher Lemmer Webber wrote:
> Fix attached.  Ok to push?
> 

Looks good to me. I will note however that the test suite doesn't seem
to actually be run.

> From 1fc31863857361e9f88d92cbea2099fd7ea03b10 Mon Sep 17 00:00:00 2001
> From: Christopher Lemmer Webber <cwebber@dustycloud.org>
> Date: Wed, 1 Jul 2020 16:36:29 -0400
> Subject: [PATCH] gnu: python-grequests: Fix tests by adding zope dependencies.
> 
> * gnu/packages/python-web.scm (python-grequests): Add zope
>   dependencies to native-inputs for tests.

should be:

* gnu/packages/python-web.scm (python-grequests)[native-inputs]:
Add python-zope.interface, python-zope.event.


> ---
>  gnu/packages/python-web.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 030abef9c2..c929e254f7 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -2010,7 +2010,9 @@ library.")
>       `(("python-gevent" ,python-gevent)
>         ("python-requests" ,python-requests)))
>      (native-inputs
> -     `(("python-nose" ,python-nose)))
> +     `(("python-nose" ,python-nose)
> +       ("python-zope.interface" ,python-zope-interface)
> +       ("python-zope.event" ,python-zope-event)))
>      (home-page "https://github.com/kennethreitz/grequests")
>      (synopsis "Python library for asynchronous HTTP requests")
>      (description "GRequests is a Python library that allows you to use
> -- 
> 2.26.2
> 


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-07-02  7:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 20:39 bug#42158: python-grequests broken, add zope dependencies to fix Christopher Lemmer Webber
2020-07-02  7:27 ` Efraim Flashner [this message]
2020-07-02 12:16   ` Christopher Lemmer Webber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702072733.GF6387@E5400 \
    --to=efraim@flashner.co.il \
    --cc=42158@debbugs.gnu.org \
    --cc=cwebber@dustycloud.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).