From: Ricardo Wurmus <rekado@elephly.net>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 43296@debbugs.gnu.org
Subject: bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build.
Date: Thu, 10 Sep 2020 20:23:53 +0200 [thread overview]
Message-ID: <87a6xx4hja.fsf@elephly.net> (raw)
In-Reply-To: <20200910165827.13274-2-leo.prikler@student.tugraz.at>
Leo Prikler <leo.prikler@student.tugraz.at> writes:
> As reported in #43296, gnome-builder tries to be linked against the static
> version of libselinux (propagated through glib/gio), failing to do so, as it
> also wants to be a PIE. To keep the PIE, link it against the dynamic library.
> * gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja.
> ---
> gnu/packages/gnome.scm | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 31c5b0319c..ff4cb8a383 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -11336,6 +11336,12 @@ libraries. Applications do not need to be recompiled--or even restarted.")
> (string-append (assoc-ref inputs "python-pygobject")
> "/lib")))
> #t))
> + (add-after 'configure 'fix-ninja
> + (lambda _
> + ;; #43296: meson(?) incorrectly assumes we want to link
> + ;; this PIE against a static libselinux.
> + (substitute* "build.ninja"
> + (("libselinux\\.a") "libselinux.so"))))
Please end the phase on #t, because “substitute*” has no specified
return value.
Other than that it looks good to me, thanks!
--
Ricardo
next prev parent reply other threads:[~2020-09-10 18:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 19:04 bug#43296: Gnome Builder doesn't install Marinus Savoritias
2020-09-10 16:58 ` bug#43296: bug#43269: " Leo Prikler
2020-09-10 16:58 ` bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build Leo Prikler
2020-09-10 18:08 ` Mark H Weaver
2020-09-10 18:23 ` Ricardo Wurmus [this message]
2020-09-10 18:26 ` bug#43296: [PATCH] " Leo Prikler
2020-10-31 16:56 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6xx4hja.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=43296@debbugs.gnu.org \
--cc=leo.prikler@student.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).