From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wJYiGKh1Wl+gPQAA0tVLHw (envelope-from ) for ; Thu, 10 Sep 2020 18:51:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +BgIFKh1Wl+AQgAAbx9fmQ (envelope-from ) for ; Thu, 10 Sep 2020 18:51:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B424E940291 for ; Thu, 10 Sep 2020 18:51:19 +0000 (UTC) Received: from localhost ([::1]:37556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGRfC-0007I7-G4 for larch@yhetil.org; Thu, 10 Sep 2020 14:51:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGRDq-0008Eg-Ge for bug-guix@gnu.org; Thu, 10 Sep 2020 14:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57844) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGRDq-0003Ie-5U for bug-guix@gnu.org; Thu, 10 Sep 2020 14:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGRDq-0004Vr-1x for bug-guix@gnu.org; Thu, 10 Sep 2020 14:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build. Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 10 Sep 2020 18:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43296 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Leo Prikler Received: via spool by 43296-submit@debbugs.gnu.org id=B43296.159976216517309 (code B ref 43296); Thu, 10 Sep 2020 18:23:02 +0000 Received: (at 43296) by debbugs.gnu.org; 10 Sep 2020 18:22:45 +0000 Received: from localhost ([127.0.0.1]:41157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGRDZ-0004V6-2Y for submit@debbugs.gnu.org; Thu, 10 Sep 2020 14:22:45 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGRDX-0004Uy-4a for 43296@debbugs.gnu.org; Thu, 10 Sep 2020 14:22:43 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1599762162; cv=none; d=zohomail.com; s=zohoarc; b=m8DnzKgkOYppDXn92NTTs2o4Ucrg1glldTenRJ2ldby7JHaUg+MCX7pmdgNUKyRN0AQg3ZPV/3lc3hRG3Pz4stXbi0QW4dUT0zGGP7BU+eDdk5m3LZgXC49Ea6JNYA+VTbQ5sKER+Ty1j1HG5bJGfzTXmuPnDqOlKTxiOjugcgo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599762162; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=FR8t29SjrOeSDlYWXHfhWgDeaajI9JPFtx8lBrU3+44=; b=ABs1ffgmx+mKwR0OW81ZQiLnpv0n1b4dfan32W2FP4ZKdHXKHwtZRjK45CejH+HWWhaszMnE2hjaxSdZYjOKKX+TqbOihQD637nUSVwTIcyGz/gXW0jf59KDxRThU7H6imQ2myFaILjSR+lSJs/nfj+1l9lK51Q0PTqPB4vqix8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1599762162; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=FR8t29SjrOeSDlYWXHfhWgDeaajI9JPFtx8lBrU3+44=; b=JEJtwosz0OcKfqu/3/r7+BTDltnLuu67veR94kA6oT3GWkOMNsCzVSLKoDeEmyUA U9lEt+LZcfq+4TIVbkw8Kj9JWYGa2Go8hOW3pEOePIdYtoO/a19HSvKSaO98pg7jF3F 4tmvMPcY9wb94grfJz6McT/z3eqGlpJksnAOx8ZE= Received: from localhost (p54ad4af6.dip0.t-ipconnect.de [84.173.74.246]) by mx.zohomail.com with SMTPS id 15997621597066.5768608755511195; Thu, 10 Sep 2020 11:22:39 -0700 (PDT) References: <20200910165827.13274-1-leo.prikler@student.tugraz.at> <20200910165827.13274-2-leo.prikler@student.tugraz.at> User-agent: mu4e 1.4.13; emacs 27.1 From: Ricardo Wurmus In-reply-to: <20200910165827.13274-2-leo.prikler@student.tugraz.at> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 10 Sep 2020 20:23:53 +0200 Message-ID: <87a6xx4hja.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43296@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=elephly.net header.s=zoho header.b=JEJtwosz; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 3.49 X-TUID: UX3egrhzwWly Leo Prikler writes: > As reported in #43296, gnome-builder tries to be linked against the static > version of libselinux (propagated through glib/gio), failing to do so, as= it > also wants to be a PIE. To keep the PIE, link it against the dynamic lib= rary. > * gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja. > --- > gnu/packages/gnome.scm | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 31c5b0319c..ff4cb8a383 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -11336,6 +11336,12 @@ libraries. Applications do not need to be recom= piled--or even restarted.") > (string-append (assoc-ref inputs "python-pygobject") > "/lib"))) > #t)) > + (add-after 'configure 'fix-ninja > + (lambda _ > + ;; #43296: meson(?) incorrectly assumes we want to link > + ;; this PIE against a static libselinux. > + (substitute* "build.ninja" > + (("libselinux\\.a") "libselinux.so")))) Please end the phase on #t, because =E2=80=9Csubstitute*=E2=80=9D has no sp= ecified return value. Other than that it looks good to me, thanks! --=20 Ricardo