unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#35923: Minification of Javascript for r-shiny fails
@ 2019-05-27 10:24 Roel Janssen
  2019-05-27 20:11 ` Ricardo Wurmus
  0 siblings, 1 reply; 2+ messages in thread
From: Roel Janssen @ 2019-05-27 10:24 UTC (permalink / raw)
  To: 35923

Dear guix,

It seems that the r-shiny package is not functioning correctly due to empty minified Javascript
files.

This is empty:
$ ls -lh ./site-library/shiny/www/shared/shiny.min.js
-r--r--r-- 6658 root root 0 Jan  1  1970 ./site-library/shiny/www/shared/shiny.min.js

While its unminified equivalent is definitely not empty:
$ ls -lh ./site-library/shiny/www/shared/shiny.js
-r--r--r-- 3 root root 229K Jan  1  1970 ./site-library/shiny/www/shared/shiny.js

Symlinking the unminified files to the minified files solves the problem.  But for production use
I'd like to get the minification to work.

Is it a trivial thing to fix for someone more familiar with the minify-build-system?

Kind regards,
Roel Janssen

^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#35923: Minification of Javascript for r-shiny fails
  2019-05-27 10:24 bug#35923: Minification of Javascript for r-shiny fails Roel Janssen
@ 2019-05-27 20:11 ` Ricardo Wurmus
  0 siblings, 0 replies; 2+ messages in thread
From: Ricardo Wurmus @ 2019-05-27 20:11 UTC (permalink / raw)
  To: Roel Janssen; +Cc: 35923-done


Hi Roel,

> It seems that the r-shiny package is not functioning correctly due to empty minified Javascript
> files.
>
> This is empty:
> $ ls -lh ./site-library/shiny/www/shared/shiny.min.js
> -r--r--r-- 6658 root root 0 Jan  1  1970 ./site-library/shiny/www/shared/shiny.min.js

Oh.  This is now fixed with commit 8916034a34.
Problem was that uglify-js wasn’t available during minification.  It
would have been nicer had the build phase failed.

-- 
Ricardo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-27 20:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-27 10:24 bug#35923: Minification of Javascript for r-shiny fails Roel Janssen
2019-05-27 20:11 ` Ricardo Wurmus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).