From: "Ludovic Courtès" <ludo@gnu.org>
To: Guillaume Le Vaillant <glv@posteo.net>
Cc: 37977-done@debbugs.gnu.org
Subject: bug#37977: Mount options ignored for root file system
Date: Mon, 18 Nov 2019 11:32:16 +0100 [thread overview]
Message-ID: <878sodlbkf.fsf@gnu.org> (raw)
In-Reply-To: <87pnhqy4cr.fsf@yamatai> (Guillaume Le Vaillant's message of "Sun, 17 Nov 2019 15:17:24 +0100")
Hello Guillaume,
Guillaume Le Vaillant <glv@posteo.net> skribis:
> The attached patch adds an 'options' parameter to
> 'mount-root-file-system' and makes 'boot-system' use it with the
> content of the 'options' field of the <file-system> object for "/".
>
> It's not exactly the solution you described (adding a keyword argument
> to 'boot-system'), but I think it should work. What do you think?
It looks great to me.
> From 3597f0fda6f6a13bf1fdab0fcde4f72ece688d93 Mon Sep 17 00:00:00 2001
> From: Guillaume Le Vaillant <glv@posteo.net>
> Date: Sun, 17 Nov 2019 14:15:21 +0100
> Subject: [PATCH] linux-boot: Don't ignore options when mounting root file
> system.
>
> * gnu/build/linux-boot.scm (mount-root-file-system): Add the 'options'
> keyword argument and use it when mounting the root file system.
> (boot-system): Pass the root file system options to
> 'mount-root-file-system'.
Applied, thanks!
Ludo’.
prev parent reply other threads:[~2019-11-18 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 10:22 bug#37977: Mount options ignored for root file system Guillaume Le Vaillant
2019-11-07 18:28 ` Guillaume Le Vaillant
2019-11-17 10:43 ` Ludovic Courtès
2019-11-17 14:17 ` Guillaume Le Vaillant
2019-11-18 10:32 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sodlbkf.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=37977-done@debbugs.gnu.org \
--cc=glv@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).