From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#37977: Mount options ignored for root file system
Date: Mon, 18 Nov 2019 11:32:16 +0100
Message-ID: <878sodlbkf.fsf@gnu.org>
References: <87pnif6ec0.fsf@yamatai> <87eeyjils5.fsf@yamatai>
 <87bltapyuc.fsf@gnu.org> <87pnhqy4cr.fsf@yamatai>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:39158)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iWeLB-0003e2-Cv
 for bug-guix@gnu.org; Mon, 18 Nov 2019 05:33:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iWeL9-00068o-3K
 for bug-guix@gnu.org; Mon, 18 Nov 2019 05:33:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:34404)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iWeL8-00068g-TW
 for bug-guix@gnu.org; Mon, 18 Nov 2019 05:33:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iWeL8-0001YF-Ob
 for bug-guix@gnu.org; Mon, 18 Nov 2019 05:33:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.37977.D37977.15740731495913.done@debbugs.gnu.org>
In-Reply-To: <87pnhqy4cr.fsf@yamatai> (Guillaume Le Vaillant's message of
 "Sun, 17 Nov 2019 15:17:24 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Guillaume Le Vaillant <glv@posteo.net>
Cc: 37977-done@debbugs.gnu.org

Hello Guillaume,

Guillaume Le Vaillant <glv@posteo.net> skribis:

> The attached patch adds an 'options' parameter to
> 'mount-root-file-system' and makes 'boot-system' use it with the
> content of the 'options' field of the <file-system> object for "/".
>=20
> It's not exactly the solution you described (adding a keyword argument
> to 'boot-system'), but I think it should work. What do you think?

It looks great to me.

> From 3597f0fda6f6a13bf1fdab0fcde4f72ece688d93 Mon Sep 17 00:00:00 2001
> From: Guillaume Le Vaillant <glv@posteo.net>
> Date: Sun, 17 Nov 2019 14:15:21 +0100
> Subject: [PATCH] linux-boot: Don't ignore options when mounting root file
>  system.
>
> * gnu/build/linux-boot.scm (mount-root-file-system): Add the 'options'
>   keyword argument and use it when mounting the root file system.
>   (boot-system): Pass the root file system options to
>   'mount-root-file-system'.

Applied, thanks!

Ludo=E2=80=99.