* bug#58495: opam import generates wrong check phase
@ 2022-10-13 15:03 Csepp
2022-10-13 15:44 ` Julien Lepiller
0 siblings, 1 reply; 6+ messages in thread
From: Csepp @ 2022-10-13 15:03 UTC (permalink / raw)
To: 58495
So I'm working on building MirageOS unikernels with Guix, which means
using the OPAM importer *a lot*, which unearths some very Fun TM bugs.
Here is the first one:
guix import opam mirage-clock
The correct check phase is this:
```
(replace 'check
(lambda* (#:key tests? #:allow-other-keys)
(invoke "dune" "runtest" "--release")))
```
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#58495: opam import generates wrong check phase
2022-10-13 15:03 bug#58495: opam import generates wrong check phase Csepp
@ 2022-10-13 15:44 ` Julien Lepiller
2022-10-13 16:16 ` Csepp
0 siblings, 1 reply; 6+ messages in thread
From: Julien Lepiller @ 2022-10-13 15:44 UTC (permalink / raw)
To: 58495, raingloom
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
Maybe this could be fixed in the dune-build-system?
Le 13 octobre 2022 17:03:43 GMT+02:00, Csepp <raingloom@riseup.net> a écrit :
>So I'm working on building MirageOS unikernels with Guix, which means
>using the OPAM importer *a lot*, which unearths some very Fun TM bugs.
>Here is the first one:
>
>guix import opam mirage-clock
>
>The correct check phase is this:
>```
>(replace 'check
> (lambda* (#:key tests? #:allow-other-keys)
> (invoke "dune" "runtest" "--release")))
>```
>
>
>
[-- Attachment #2: Type: text/html, Size: 803 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#58495: opam import generates wrong check phase
2022-10-13 15:44 ` Julien Lepiller
@ 2022-10-13 16:16 ` Csepp
2023-01-28 12:25 ` Julien Lepiller
0 siblings, 1 reply; 6+ messages in thread
From: Csepp @ 2022-10-13 16:16 UTC (permalink / raw)
To: Julien Lepiller; +Cc: 58495, raingloom
Julien Lepiller <julien@lepiller.eu> writes:
> Maybe this could be fixed in the dune-build-system?
>
Actually, good call. I'll look into it, unless you want to take a stab
at it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#58495: opam import generates wrong check phase
2022-10-13 16:16 ` Csepp
@ 2023-01-28 12:25 ` Julien Lepiller
2023-01-28 19:28 ` Csepp
0 siblings, 1 reply; 6+ messages in thread
From: Julien Lepiller @ 2023-01-28 12:25 UTC (permalink / raw)
To: Csepp; +Cc: 58495
Le Thu, 13 Oct 2022 18:16:18 +0200,
Csepp <raingloom@riseup.net> a écrit :
> Julien Lepiller <julien@lepiller.eu> writes:
>
> > Maybe this could be fixed in the dune-build-system?
> >
> Actually, good call. I'll look into it, unless you want to take a
> stab at it.
With the test-target argument removed, do you consider this fixed?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#58495: opam import generates wrong check phase
2023-01-28 12:25 ` Julien Lepiller
@ 2023-01-28 19:28 ` Csepp
2023-01-28 21:06 ` Julien Lepiller
0 siblings, 1 reply; 6+ messages in thread
From: Csepp @ 2023-01-28 19:28 UTC (permalink / raw)
To: Julien Lepiller; +Cc: 58495, raingloom
Julien Lepiller <julien@lepiller.eu> writes:
> Le Thu, 13 Oct 2022 18:16:18 +0200,
> Csepp <raingloom@riseup.net> a écrit :
>
>> Julien Lepiller <julien@lepiller.eu> writes:
>>
>> > Maybe this could be fixed in the dune-build-system?
>> >
>> Actually, good call. I'll look into it, unless you want to take a
>> stab at it.
>
> With the test-target argument removed, do you consider this fixed?
Yup, it's fixed now, thanks for closing these.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#58495: opam import generates wrong check phase
2023-01-28 19:28 ` Csepp
@ 2023-01-28 21:06 ` Julien Lepiller
0 siblings, 0 replies; 6+ messages in thread
From: Julien Lepiller @ 2023-01-28 21:06 UTC (permalink / raw)
To: Csepp; +Cc: 58495-close
Le Sat, 28 Jan 2023 20:28:59 +0100,
Csepp <raingloom@riseup.net> a écrit :
> Julien Lepiller <julien@lepiller.eu> writes:
>
> > Le Thu, 13 Oct 2022 18:16:18 +0200,
> > Csepp <raingloom@riseup.net> a écrit :
> >
> >> Julien Lepiller <julien@lepiller.eu> writes:
> >>
> >> > Maybe this could be fixed in the dune-build-system?
> >> >
> >> Actually, good call. I'll look into it, unless you want to take a
> >> stab at it.
> >
> > With the test-target argument removed, do you consider this fixed?
>
> Yup, it's fixed now, thanks for closing these.
Closing, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-28 21:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-13 15:03 bug#58495: opam import generates wrong check phase Csepp
2022-10-13 15:44 ` Julien Lepiller
2022-10-13 16:16 ` Csepp
2023-01-28 12:25 ` Julien Lepiller
2023-01-28 19:28 ` Csepp
2023-01-28 21:06 ` Julien Lepiller
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).