bug#25315: diffoscope misses inputs

bug#25315: diffoscope misses inputs

[Ricardo Wurmus]

I just installed diffoscope and ran it on two files and got this error:

--8<---------------cut here---------------start------------->8---
diffoscope /gnu/store/lf2ybanhxpvbgbxcsxmc733v010g15fp-clisp-2.49/lib/clisp-2.49/base/lispinit.mem /gnu/store/lf2ybanhxpvbgbxcsxmc733v010g15fp-clisp-2.49-check/lib/clisp-2.49/base/lispinit.mem
--- /gnu/store/lf2ybanhxpvbgbxcsxmc733v010g15fp-clisp-2.49/lib/clisp-2.49/base/lispinit.mem
+++ /gnu/store/lf2ybanhxpvbgbxcsxmc733v010g15fp-clisp-2.49-check/lib/clisp-2.49/base/lispinit.mem
│┄ xxd not available in path. Falling back to Python hexlify.

Traceback (most recent call last):
  File "/gnu/store/i0rn71jcspqr6p9lbfrghh2xkv5gmp77-diffoscope-63/lib/python3.5/site-packages/diffoscope/main.py", line 290, in main
    sys.exit(run_diffoscope(parsed_args))
  File "/gnu/store/i0rn71jcspqr6p9lbfrghh2xkv5gmp77-diffoscope-63/lib/python3.5/site-packages/diffoscope/main.py", line 268, in run_diffoscope
    output_text(difference, print_func=print_func, color=color)
  File "/gnu/store/i0rn71jcspqr6p9lbfrghh2xkv5gmp77-diffoscope-63/lib/python3.5/site-packages/diffoscope/presenters/text.py", line 59, in output_text
    print_difference(difference, print_func, color)
  File "/gnu/store/i0rn71jcspqr6p9lbfrghh2xkv5gmp77-diffoscope-63/lib/python3.5/site-packages/diffoscope/presenters/text.py", line 34, in print_difference
    diff_output = color_unified_diff(difference.unified_diff)
  File "/gnu/store/i0rn71jcspqr6p9lbfrghh2xkv5gmp77-diffoscope-63/lib/python3.5/site-packages/diffoscope/__init__.py", line 69, in tool_check
    raise RequiredToolNotFound(command)
diffoscope.exc.RequiredToolNotFound: colordiff
--8<---------------cut here---------------end--------------->8---

We either need to add xxd (from vim) or colordiff.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net

bug#25315: more missing inputs

[Ricardo Wurmus]

There are many more tools whose availability is checked for at runtime.

    @tool_required('bzip2')
    @tool_required('cbfstool')
    @tool_required('cd-iccdump')
    @tool_required('cmp')
    @tool_required('colordiff')
    @tool_required('cpio')
    @tool_required('diff')
    @tool_required('enjarify')
    @tool_required('getfacl')
    @tool_required('ghc')
    @tool_required('gpg')
    @tool_required('gzip')
    @tool_required('img2txt')
    @tool_required('isoinfo')
    @tool_required('javap')
    @tool_required('lipo')
    @tool_required('llvm-bcanalyzer')
    @tool_required('llvm-dis')
    @tool_required('lsattr')
    @tool_required('msgunfmt')
    @tool_required('nm')
    @tool_required('objcopy')
    @tool_required('objdump')
    @tool_required('otool')
    @tool_required('pdftk')
    @tool_required('pdftotext')
    @tool_required('pedump')
    @tool_required('ppudump')
    @tool_required('ps2ascii')
    @tool_required('readelf')
    @tool_required('rpm2cpio')
    @tool_required('showttf')
    @tool_required('sng')
    @tool_required('sqlite3')
    @tool_required('stat')
    @tool_required('unsquashfs')
    @tool_required('xxd')
    @tool_required('xz')
    @tool_required('zipinfo')

Not all of them are necessarily needed in a default installation of
diffoscope, but at least some of them are required.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net

bug#25315: more missing inputs

[Ricardo Wurmus]

Fixed with 5dbeccf5b4f534dd5519691dfdf58a6921c9f343, which embeds
references for xxd, colordiff, and readelf.