bug#30434: magit won’t work over TRAMP

[Mark H Weaver <mhw@netris.org>]

Hi Alex,

Alex Kost <alezost@gmail.com> writes:

> Mark H Weaver (2018-02-14 03:51 -0500) wrote:
>
>> Ricardo Wurmus <rekado@elephly.net> writes:
>>> I think it makes sense *not* to hardcode the path to the git executable
>>> here.
>>
>> Agreed.  Done, in commit 5fe9ba59ba1cea12a70d011aacbace52e3bfda18 on
>> master and commit 317e8e9404058af35d9843e076934560f95d895a on
>> core-updates.  I'm closing this bug now.
>
> You didn't remove "git" from the inputs.  I think it is not needed now.

I removed it on my first attempt, but the build failed.  See below.

      Mark

--8<---------------cut here---------------start------------->8---
starting phase `build'
Cannot open load file: No such file or directory, /tmp/guix-build-magit-2.11.0.drv-0/magit-2.11.0/magit-version.el
make[1]: Entering directory '/tmp/guix-build-magit-2.11.0.drv-0/magit-2.11.0/Documentation'
make[1]: Entering directory '/tmp/guix-build-magit-2.11.0.drv-0/magit-2.11.0/lisp'
Cannot open load file: No such file or directory, /tmp/guix-build-magit-2.11.0.drv-0/magit-2.11.0/Documentation/magit-version.el
Generating magit.info
Compiling git-commit.el
Compiling magit-popup.el
Compiling magit-utils.el
Generating magit-autoloads.el
Generating magit-version.el
Compiling magit-section.el
Compiling magit-git.el
Compiling magit-mode.el
Compiling magit-margin.el
Compiling magit-process.el
Generating magit-popup.info
Compiling magit-autorevert.el
Compiling magit-core.el
Compiling magit-diff.el
Generating dir
make[1]: Leaving directory '/tmp/guix-build-magit-2.11.0.drv-0/magit-2.11.0/Documentation'
Compiling magit-repos.el
Compiling magit-log.el
Compiling magit-wip.el
Compiling magit-apply.el
Compiling magit.el
Compiling magit-refs.el
Compiling magit-status.el

In toplevel form:
magit-status.el:30:1:Error: Searching for program: No such file or directory, git
make[1]: *** [Makefile:61: magit-status.elc] Error 1
make[1]: *** Waiting for unfinished jobs....

In toplevel form:
magit-refs.el:30:1:Error: Searching for program: No such file or directory, git
make[1]: *** [Makefile:61: magit-refs.elc] Error 1
make[1]: Leaving directory '/tmp/guix-build-magit-2.11.0.drv-0/magit-2.11.0/lisp'
make: *** [Makefile:75: lisp] Error 2
phase `build' failed after 7.5 seconds
--8<---------------cut here---------------end--------------->8---