* bug#34927: Curl is not configured to use its dependency libssh2
@ 2019-03-20 20:40 Leo Famulari
2019-03-20 23:54 ` Marius Bakke
0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2019-03-20 20:40 UTC (permalink / raw)
To: 34927
[-- Attachment #1: Type: text/plain, Size: 694 bytes --]
While working on a libssh2 update [0] I noticed that curl was not
keeping a reference to libssh2, even though libssh2 is an input of the
curl build.
Our curl package is missing the required configuration option:
------
SSH support: no (--with-libssh2)
------
I assume that our curl package did build with SSH support in the past,
but I'm not sure.
It's unfortunate that we have to use a graft to update libssh2 even
though only a few dozen packages refer to it, because of this curl
issue.
What should we do about curl? Should we remove libssh2 from its inputs,
or enable the build-time --with-libssh2 configuration option?
[0]
https://bugs.gnu.org/34926
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#34927: Curl is not configured to use its dependency libssh2
2019-03-20 20:40 bug#34927: Curl is not configured to use its dependency libssh2 Leo Famulari
@ 2019-03-20 23:54 ` Marius Bakke
2019-03-21 17:38 ` Leo Famulari
0 siblings, 1 reply; 6+ messages in thread
From: Marius Bakke @ 2019-03-20 23:54 UTC (permalink / raw)
To: Leo Famulari, 34927
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
Leo Famulari <leo@famulari.name> writes:
> While working on a libssh2 update [0] I noticed that curl was not
> keeping a reference to libssh2, even though libssh2 is an input of the
> curl build.
>
> Our curl package is missing the required configuration option:
>
> ------
> SSH support: no (--with-libssh2)
> ------
>
> I assume that our curl package did build with SSH support in the past,
> but I'm not sure.
>
> It's unfortunate that we have to use a graft to update libssh2 even
> though only a few dozen packages refer to it, because of this curl
> issue.
>
> What should we do about curl? Should we remove libssh2 from its inputs,
> or enable the build-time --with-libssh2 configuration option?
Since no one apparently uses it, let's just remove it. I'm something of
a curl power user and did not know it even had SSH support!
In the mean time, if curl is the only "heavy" user of libssh2, we
can give it a non-public or hidden libssh2 package that stays on version
1.8.0 to avoid the graft. WDYT?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#34927: Curl is not configured to use its dependency libssh2
2019-03-20 23:54 ` Marius Bakke
@ 2019-03-21 17:38 ` Leo Famulari
2019-03-21 19:06 ` Marius Bakke
0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2019-03-21 17:38 UTC (permalink / raw)
To: Marius Bakke; +Cc: 34927
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On Thu, Mar 21, 2019 at 12:54:02AM +0100, Marius Bakke wrote:
> Since no one apparently uses it, let's just remove it. I'm something of
> a curl power user and did not know it even had SSH support!
>
> In the mean time, if curl is the only "heavy" user of libssh2, we
> can give it a non-public or hidden libssh2 package that stays on version
> 1.8.0 to avoid the graft. WDYT?
Good idea! Done in af8f7eb4f2a664c2d0fb3faabaf2e80c72993ef6
I'll leave this bug open until curl either uses libssh2 or we remove the
dependency.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#34927: Curl is not configured to use its dependency libssh2
2019-03-21 17:38 ` Leo Famulari
@ 2019-03-21 19:06 ` Marius Bakke
2019-03-21 20:37 ` Leo Famulari
0 siblings, 1 reply; 6+ messages in thread
From: Marius Bakke @ 2019-03-21 19:06 UTC (permalink / raw)
To: Leo Famulari; +Cc: 34927, guix-sysadmin
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Thu, Mar 21, 2019 at 12:54:02AM +0100, Marius Bakke wrote:
>> Since no one apparently uses it, let's just remove it. I'm something of
>> a curl power user and did not know it even had SSH support!
>>
>> In the mean time, if curl is the only "heavy" user of libssh2, we
>> can give it a non-public or hidden libssh2 package that stays on version
>> 1.8.0 to avoid the graft. WDYT?
>
> Good idea! Done in af8f7eb4f2a664c2d0fb3faabaf2e80c72993ef6
This commit changed the cURL derivation, so I pushed a followup in
c1f4e6491cecc5d121ef371a8fb2aa0a07030d36.
I think using the "hidden?" property will leave the derivation
unchanged (as opposed to (hidden-package ...)).
@guix-sysadmin: Can you cancel evaluation 4309 on Berlin?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#34927: Curl is not configured to use its dependency libssh2
2019-03-21 19:06 ` Marius Bakke
@ 2019-03-21 20:37 ` Leo Famulari
2019-03-21 21:02 ` Marius Bakke
0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2019-03-21 20:37 UTC (permalink / raw)
To: Marius Bakke; +Cc: 34927-done, guix-sysadmin
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
On Thu, Mar 21, 2019 at 08:06:24PM +0100, Marius Bakke wrote:
> This commit changed the cURL derivation, so I pushed a followup in
> c1f4e6491cecc5d121ef371a8fb2aa0a07030d36.
Oops... I did check that the libssh2 derivation had not changed, but I
didn't expect the order of the inputs in the curl package definition to
affect the derivation. Thanks for you quick fix!
> I think using the "hidden?" property will leave the derivation
> unchanged (as opposed to (hidden-package ...)).
(hidden-package) does work to preserve the derivation — the issue was
the inputs ordering in the curl package definition. I pushed another
followup to use it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#34927: Curl is not configured to use its dependency libssh2
2019-03-21 20:37 ` Leo Famulari
@ 2019-03-21 21:02 ` Marius Bakke
0 siblings, 0 replies; 6+ messages in thread
From: Marius Bakke @ 2019-03-21 21:02 UTC (permalink / raw)
To: Leo Famulari; +Cc: 34927-done
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Thu, Mar 21, 2019 at 08:06:24PM +0100, Marius Bakke wrote:
>> This commit changed the cURL derivation, so I pushed a followup in
>> c1f4e6491cecc5d121ef371a8fb2aa0a07030d36.
>
> Oops... I did check that the libssh2 derivation had not changed, but I
> didn't expect the order of the inputs in the curl package definition to
> affect the derivation. Thanks for you quick fix!
>
>> I think using the "hidden?" property will leave the derivation
>> unchanged (as opposed to (hidden-package ...)).
>
> (hidden-package) does work to preserve the derivation — the issue was
> the inputs ordering in the curl package definition. I pushed another
> followup to use it.
Oops, indeed it does.. I must have mixed it up with something else,
thanks for correcting my flawed assumption :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-21 21:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 20:40 bug#34927: Curl is not configured to use its dependency libssh2 Leo Famulari
2019-03-20 23:54 ` Marius Bakke
2019-03-21 17:38 ` Leo Famulari
2019-03-21 19:06 ` Marius Bakke
2019-03-21 20:37 ` Leo Famulari
2019-03-21 21:02 ` Marius Bakke
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).