bug#39607: GRUB module all_video required to get video on 4K monitor

bug#39607: GRUB module all_video required to get video on 4K monitor

[Maxim Cournoyer]

Hello,

I installed Guix System on a new machine, which displays on a 4K (3840 x
2160 pixels) monitor.

Unless I go to the GRUB command prompt with 'c' at boot and type 'insmod
all_video', the video cuts early after booting a GRUB entry with 'No
suitable video mode found', or similar.

I think we should include this GRUB module in our default GRUB
package/configuration.

Maxim

bug#39607: GRUB module all_video required to get video on 4K monitor

[Maxim Cournoyer]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Hello,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hello,
>
> I installed Guix System on a new machine, which displays on a 4K (3840 x
> 2160 pixels) monitor.
>
> Unless I go to the GRUB command prompt with 'c' at boot and type 'insmod
> all_video', the video cuts early after booting a GRUB entry with 'No
> suitable video mode found', or similar.
>
> I think we should include this GRUB module in our default GRUB
> package/configuration.
>
> Maxim

I think the attached patches fixes this issue, and makes the
GRUB configuration a bit simpler too!


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-bootloader-grub-Use-the-all_video-module-in-graphic-.patch --]
[-- Type: text/x-patch, Size: 1352 bytes --]

From 115cc43361c72b3bae0d89e03f328e4383d9e9be Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Wed, 19 Feb 2020 15:35:46 -0500
Subject: [PATCH 1/2] bootloader: grub: Use the all_video module in graphic
 mode.

Fixes <https://bugs.gnu.org/39467>.

* gnu/bootloader/grub.scm (eye-candy): Load the module 'all_video'
which automatically loads all the available and relevant video
modules.
---
 gnu/bootloader/grub.scm | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
index 3ec960abd8..c1cee78a16 100644
--- a/gnu/bootloader/grub.scm
+++ b/gnu/bootloader/grub.scm
@@ -163,21 +163,8 @@ system string---e.g., \"x86_64-linux\"."
                (string-append "set gfxmode=" (string-join gfxmode ";"))
                "# Leave 'gfxmode' to 'auto'."))
          "
-  insmod video_bochs
-  insmod video_cirrus
+  insmod all_video
   insmod gfxterm
-
-  if [ \"${grub_platform}\" == efi ]; then
-    # This is for (U)EFI systems (these modules are unavailable in the
-    # non-EFI GRUB.)  If we don't load them, GRUB boots in \"blind mode\",
-    # which isn't convenient.
-    insmod efi_gop
-    insmod efi_uga
-  else
-    # These are specific to non-EFI Intel machines.
-    insmod vbe
-    insmod vga
-  fi
 ")
         ""))
 
-- 
2.25.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-bootloader-grub-Refactor-eye-candy-a-bit.patch --]
[-- Type: text/x-patch, Size: 2863 bytes --]

From 5892917e2e56535deba9579a3013b54177fadc57 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Wed, 19 Feb 2020 15:59:06 -0500
Subject: [PATCH 2/2] bootloader: grub: Refactor eye-candy a bit.

* gnu/bootloader/grub.scm (eye-candy)[setup-gfxterm-body]: Define the GFXMODE
binding using AND-LET* instead of chained AND=>.  Add a comment about
supporting graphical mode on other systems than x86. Generate configuration
string using FORMAT rather than STRING-APPEND.
---
 gnu/bootloader/grub.scm | 37 ++++++++++++++++++++-----------------
 1 file changed, 20 insertions(+), 17 deletions(-)

diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
index c1cee78a16..d81e990cea 100644
--- a/gnu/bootloader/grub.scm
+++ b/gnu/bootloader/grub.scm
@@ -36,6 +36,7 @@
   #:use-module (ice-9 match)
   #:use-module (ice-9 regex)
   #:use-module (srfi srfi-1)
+  #:use-module (srfi srfi-2)
   #:export (grub-image
             grub-image?
             grub-image-aspect-ratio
@@ -149,24 +150,26 @@ STORE-MOUNT-POINT is its mount point; these are used to determine where the
 background image and fonts must be searched for.  SYSTEM must be the target
 system string---e.g., \"x86_64-linux\"."
   (define setup-gfxterm-body
-    ;; Intel and EFI systems need to be switched into graphics mode, whereas
-    ;; most other modern architectures have no other mode and therefore don't
-    ;; need to be switched.
-    (if (string-match "^(x86_64|i[3-6]86)-" system)
-        (string-append
-         "
-"
-         (let ((gfxmode (and=>
-                         (and=> config bootloader-configuration-theme)
-                         grub-gfxmode)))
-           (if gfxmode
-               (string-append "set gfxmode=" (string-join gfxmode ";"))
-               "# Leave 'gfxmode' to 'auto'."))
-         "
+    (let ((gfxmode
+           (or (and-let* ((theme (bootloader-configuration-theme config))
+                          (gfxmode (grub-gfxmode theme)))
+                 (string-join gfxmode ";"))
+               "auto")))
+
+      ;; Intel and EFI systems need to be switched into graphics mode, whereas
+      ;; most other modern architectures have no other mode and therefore
+      ;; don't need to be switched.
+
+      ;; XXX: Do we really need to restrict to x86 systems?  We could imitate
+      ;; what the GRUB default configuration does and decide based on whether
+      ;; a user provided 'gfxterm' in the terminal-outputs field of their
+      ;; bootloader-configuration record.
+      (if (string-match "^(x86_64|i[3-6]86)-" system)
+          (format #f "
+  set gfxmode=~a
   insmod all_video
-  insmod gfxterm
-")
-        ""))
+  insmod gfxterm~%" gfxmode)
+          "")))
 
   (define (setup-gfxterm config font-file)
     (if (memq 'gfxterm (bootloader-configuration-terminal-outputs config))
-- 
2.25.0

bug#39607: GRUB module all_video required to get video on 4K monitor

[Maxim Cournoyer]

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hello,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> Hello,
>>
>> I installed Guix System on a new machine, which displays on a 4K (3840 x
>> 2160 pixels) monitor.
>>
>> Unless I go to the GRUB command prompt with 'c' at boot and type 'insmod
>> all_video', the video cuts early after booting a GRUB entry with 'No
>> suitable video mode found', or similar.
>>
>> I think we should include this GRUB module in our default GRUB
>> package/configuration.
>>
>> Maxim
>
> I think the attached patches fixes this issue, and makes the
> GRUB configuration a bit simpler too!

While the patches above are an improvement over the current situation,
it still doesn't resolve my problem.  I still get the 'No suitable video
modes, booting in blind mode' message after activating a GRUB entry,
unless I manually "insmod all_video"...

Here's my grub.cfg, along with a blank one generated by 'grub-mkconfig'
for comparison.


[-- Attachment #2: grub.cfg --]
[-- Type: text/plain, Size: 6329 bytes --]

# This file was generated from your Guix configuration.  Any changes
# will be lost upon reconfiguration.

function setup_gfxterm {
  set gfxmode=auto
  insmod all_video
  insmod gfxterm
}

# Set 'root' to the partition that contains /gnu/store.
search --label --set btrfs-pool-1

if loadfont /gnu/store/m1fx9h7gzw78k0n4da0khbga5i6k8ipk-grub-2.04/share/grub/unicode.pf2; then
  setup_gfxterm
fi

terminal_output gfxterm


insmod png
if background_image /gnu/store/xn6hf7a9f1242siybkb7cqh7v2x67qrh-grub-image.png; then
  set color_normal=light-gray/black
  set color_highlight=yellow/black
else
  set menu_color_normal=cyan/blue
  set menu_color_highlight=white/blue
fi
insmod keylayouts
keymap /gnu/store/ibdld2935pbkg2fkrmh2z5fjyvas0ixd-grub-keymap.dvorak

set default=0
set timeout=5
menuentry "GNU with Linux-Libre 5.4.18" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/a0499drlaqfzkyqb8fzbk0za49nzpi0k-linux-libre-5.4.18/bzImage --root=btrfs-pool-1 --system=/gnu/store/ddnd4h65g3d6chknfsbkchd3xdqdhwd8-system --load=/gnu/store/ddnd4h65g3d6chknfsbkchd3xdqdhwd8-system/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/s0l9md1vx0sw7rky9c9nh7xlmnczxk8g-raw-initrd/initrd.cpio.gz
}

submenu "GNU system, old configurations..." {
menuentry "GNU with Linux-Libre 5.4.18 (#12, 2020-02-20 14:25)" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/a0499drlaqfzkyqb8fzbk0za49nzpi0k-linux-libre-5.4.18/bzImage --root=btrfs-pool-1 --system=/var/guix/profiles/system-12-link --load=/var/guix/profiles/system-12-link/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/cf2qwll5nlr1i7cndxl90vlnx79bwnrq-raw-initrd/initrd.cpio.gz
}
menuentry "GNU with Linux-Libre 5.4.18 (#11, 2020-02-19 21:46)" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/a0499drlaqfzkyqb8fzbk0za49nzpi0k-linux-libre-5.4.18/bzImage --root=btrfs-pool-1 --system=/var/guix/profiles/system-11-link --load=/var/guix/profiles/system-11-link/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/cf2qwll5nlr1i7cndxl90vlnx79bwnrq-raw-initrd/initrd.cpio.gz
}
menuentry "GNU with Linux-Libre 5.4.18 (#10, 2020-02-19 21:45)" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/a0499drlaqfzkyqb8fzbk0za49nzpi0k-linux-libre-5.4.18/bzImage --root=btrfs-pool-1 --system=/var/guix/profiles/system-10-link --load=/var/guix/profiles/system-10-link/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/cf2qwll5nlr1i7cndxl90vlnx79bwnrq-raw-initrd/initrd.cpio.gz
}
menuentry "GNU with Linux-Libre 5.4.18 (#9, 2020-02-19 16:57)" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/a0499drlaqfzkyqb8fzbk0za49nzpi0k-linux-libre-5.4.18/bzImage --root=btrfs-pool-1 --system=/var/guix/profiles/system-9-link --load=/var/guix/profiles/system-9-link/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/cf2qwll5nlr1i7cndxl90vlnx79bwnrq-raw-initrd/initrd.cpio.gz
}
menuentry "GNU with Linux-Libre 5.4.18 (#8, 2020-02-19 16:54)" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/a0499drlaqfzkyqb8fzbk0za49nzpi0k-linux-libre-5.4.18/bzImage --root=btrfs-pool-1 --system=/var/guix/profiles/system-8-link --load=/var/guix/profiles/system-8-link/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/k63b8daqn4cdba3a3sxjjvpz3kil078p-raw-initrd/initrd.cpio.gz
}
menuentry "GNU with Linux-Libre 5.4.18 (#7, 2020-02-17 09:25)" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/a0499drlaqfzkyqb8fzbk0za49nzpi0k-linux-libre-5.4.18/bzImage --root=btrfs-pool-1 --system=/var/guix/profiles/system-7-link --load=/var/guix/profiles/system-7-link/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/jyak0q5b5wjxiishkv4cfgd1xplrxg9r-raw-initrd/initrd.cpio.gz
}
menuentry "GNU with Linux-Libre 5.4.18 (#6, 2020-02-17 09:23)" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/a0499drlaqfzkyqb8fzbk0za49nzpi0k-linux-libre-5.4.18/bzImage --root=btrfs-pool-1 --system=/var/guix/profiles/system-6-link --load=/var/guix/profiles/system-6-link/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/jyak0q5b5wjxiishkv4cfgd1xplrxg9r-raw-initrd/initrd.cpio.gz
}
menuentry "GNU with Linux-Libre 5.4.18 (#5, 2020-02-17 09:06)" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/a0499drlaqfzkyqb8fzbk0za49nzpi0k-linux-libre-5.4.18/bzImage --root=btrfs-pool-1 --system=/var/guix/profiles/system-5-link --load=/var/guix/profiles/system-5-link/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/jyak0q5b5wjxiishkv4cfgd1xplrxg9r-raw-initrd/initrd.cpio.gz
}
menuentry "GNU with Linux-Libre 5.4.18 (#4, 2020-02-17 09:03)" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/a0499drlaqfzkyqb8fzbk0za49nzpi0k-linux-libre-5.4.18/bzImage --root=btrfs-pool-1 --system=/var/guix/profiles/system-4-link --load=/var/guix/profiles/system-4-link/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/jyak0q5b5wjxiishkv4cfgd1xplrxg9r-raw-initrd/initrd.cpio.gz
}
menuentry "GNU with Linux-Libre 5.4.18 (#3, 2020-02-13 17:17)" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/a0499drlaqfzkyqb8fzbk0za49nzpi0k-linux-libre-5.4.18/bzImage --root=btrfs-pool-1 --system=/var/guix/profiles/system-3-link --load=/var/guix/profiles/system-3-link/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/wf9c6l2m72frgclm65f912y325nksf82-raw-initrd/initrd.cpio.gz
}
menuentry "GNU with Linux-Libre 5.4.12 (#2, 2020-02-13 16:21)" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/3mm35rmk19cmsdy6hfsqgrdfbc7s199a-linux-libre-5.4.12/bzImage --root=btrfs-pool-1 --system=/var/guix/profiles/system-2-link --load=/var/guix/profiles/system-2-link/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/d6df8q8nwhf61jgw0ial4rnw6xa00bs6-raw-initrd/initrd.cpio.gz
}
menuentry "GNU with Linux-Libre 5.4.18 (#1, 2020-02-13 15:10)" {
  search --label --set btrfs-pool-1
  linux /rootfs/gnu/store/a0499drlaqfzkyqb8fzbk0za49nzpi0k-linux-libre-5.4.18/bzImage --root=btrfs-pool-1 --system=/var/guix/profiles/system-1-link --load=/var/guix/profiles/system-1-link/boot quiet modprobe.blacklist=radeon
  initrd /rootfs/gnu/store/jyak0q5b5wjxiishkv4cfgd1xplrxg9r-raw-initrd/initrd.cpio.gz
}
}

if [ "${grub_platform}" == efi ]; then
  menuentry "Firmware setup" {
    fwsetup
  }
fi

[-- Attachment #3: grub-mkconfig generated --]
[-- Type: text/plain, Size: 2986 bytes --]

#
# DO NOT EDIT THIS FILE
#
# It is automatically generated by grub-mkconfig using templates
# from /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d and settings from /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/default/grub
#

### BEGIN /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d/00_header ###
if [ -s $prefix/grubenv ]; then
  load_env
fi
if [ "${next_entry}" ] ; then
   set default="${next_entry}"
   set next_entry=
   save_env next_entry
   set boot_once=true
else
   set default="0"
fi

if [ x"${feature_menuentry_id}" = xy ]; then
  menuentry_id_option="--id"
else
  menuentry_id_option=""
fi

export menuentry_id_option

if [ "${prev_saved_entry}" ]; then
  set saved_entry="${prev_saved_entry}"
  save_env saved_entry
  set prev_saved_entry=
  save_env prev_saved_entry
  set boot_once=true
fi

function savedefault {
  if [ -z "${boot_once}" ]; then
    saved_entry="${chosen}"
    save_env saved_entry
  fi
}

function load_video {
  if [ x$feature_all_video_module = xy ]; then
    insmod all_video
  else
    insmod efi_gop
    insmod efi_uga
    insmod ieee1275_fb
    insmod vbe
    insmod vga
    insmod video_bochs
    insmod video_cirrus
  fi
}

if loadfont unicode ; then
  set gfxmode=auto
  load_video
  insmod gfxterm
  set locale_dir=$prefix/locale
  set lang=en_US
  insmod gettext
fi
terminal_output gfxterm
if [ x$feature_timeout_style = xy ] ; then
  set timeout_style=menu
  set timeout=5
# Fallback normal timeout code in case the timeout_style feature is
# unavailable.
else
  set timeout=5
fi
### END /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d/00_header ###

### BEGIN /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d/10_linux ###

### END /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d/10_linux ###

### BEGIN /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d/20_linux_xen ###
### END /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d/20_linux_xen ###

### BEGIN /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d/30_os-prober ###
### END /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d/30_os-prober ###

### BEGIN /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d/40_custom ###
# This file provides an easy way to add custom menu entries.  Simply type the
# menu entries you want to add after this comment.  Be careful not to change
# the 'exec tail' line above.
### END /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d/40_custom ###

### BEGIN /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d/41_custom ###
if [ -f  ${config_directory}/custom.cfg ]; then
  source ${config_directory}/custom.cfg
elif [ -z "${config_directory}" -a -f  $prefix/custom.cfg ]; then
  source $prefix/custom.cfg;
fi
### END /gnu/store/3433z5hdwsxks216d4xmv1nm44ycy1jc-grub-efi-2.04/etc/grub.d/41_custom ###

bug#39607: Status: GRUB module all_video required to get video on 4K monitor

[Maxim Cournoyer]

Update, after debugging: the failure to find a working video mode had
nothing to do with the 4K monitor, and everything to do with a problem
in our GRUB configuration generator and having /gnu/store on a Btrfs
submodule.

In particular, this generated pice of GRUB configuration:

--8<---------------cut here---------------start------------->8---
if loadfont /rootfs/gnu/store/m1fx9h7gzw78k0n4da0khbga5i6k8ipk-grub-2.04/share/grub/unicode.pf2; then
  setup_gfxterm
fi
--8<---------------cut here---------------end--------------->8---

was causing the setup_gfxterm to not be called due to failing to resolve
the unicode.pf2 file when using a Btrfs submodule.

The originally attached patches still provide some >
simplification/cleanup that would make it good to merge nontheless, I
believe!

Maxim

bug#39607: GRUB module all_video required to get video on 4K monitor

[Maxim Cournoyer]

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hello,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> Hello,
>>
>> I installed Guix System on a new machine, which displays on a 4K (3840 x
>> 2160 pixels) monitor.
>>
>> Unless I go to the GRUB command prompt with 'c' at boot and type 'insmod
>> all_video', the video cuts early after booting a GRUB entry with 'No
>> suitable video mode found', or similar.
>>
>> I think we should include this GRUB module in our default GRUB
>> package/configuration.
>>
>> Maxim
>
> I think the attached patches fixes this issue, and makes the
> GRUB configuration a bit simpler too!

Merge to master with commit 6794653e1b.  Closing!