bug#64008: shepherd respawns a service even when it's disabled

bug#64008: shepherd respawns a service even when it's disabled

[Attila Lendvai]

the issue:

i'm in a situation where my service quits after a few seconds of CPU usage (i.e. the default-respawn-limit is not triggered). therefore shepherd keeps restarting it, practically in a busy loop.

suggested solution:

maybe respawn-service should check for the disabled state, so that the admin can intervene by `herd disable myservice`.

a longer term solution could be to add a respawn-delay field for <service>, and default it to something non-zero.

-- 
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
The mind: an excellent servant, but a dangerous master.

bug#64008: shepherd respawns a service even when it's disabled

[Attila Lendvai]

i forgot to mention that the service is in the stopped state while this is happening, at least according to `herd status`.

-- 
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“Most of our lives, most of us live in realities determined by others, imprinted in our brains by education, by religion, by politics, by the authorities.”
	— Timothy Leary (1920–1996)

bug#64008: shepherd respawns a service even when it's disabled

[Ludovic Courtès]

Hi Attila,

Attila Lendvai <attila@lendvai.name> skribis:

> i'm in a situation where my service quits after a few seconds of CPU usage (i.e. the default-respawn-limit is not triggered). therefore shepherd keeps restarting it, practically in a busy loop.
>
> suggested solution:
>
> maybe respawn-service should check for the disabled state, so that the admin can intervene by `herd disable myservice`.

Turns out the service controller was ignoring the ‘enabled?’  flag,
leaving it up to the caller to check it.

This is fixed by Shepherd commit
7c88d67076a0bb1d9014b3bc23ed9c68f1c702ab.

Thanks again,
Ludo’.