unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#65457: qtbase refers to python 3
@ 2023-08-22 18:18 Maxim Cournoyer
  2023-08-22 19:13 ` Maxim Cournoyer
  0 siblings, 1 reply; 2+ messages in thread
From: Maxim Cournoyer @ 2023-08-22 18:18 UTC (permalink / raw)
  To: 65457

Hi,

I failed to notice this in time for the merge, but it appears qtbase now
keeps a reference to Python 3.10, which increases its size a bit.

It should be removed.

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#65457: qtbase refers to python 3
  2023-08-22 18:18 bug#65457: qtbase refers to python 3 Maxim Cournoyer
@ 2023-08-22 19:13 ` Maxim Cournoyer
  0 siblings, 0 replies; 2+ messages in thread
From: Maxim Cournoyer @ 2023-08-22 19:13 UTC (permalink / raw)
  To: 65457-done

Hello,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hi,
>
> I failed to notice this in time for the merge, but it appears qtbase now
> keeps a reference to Python 3.10, which increases its size a bit.
>
> It should be removed.

Fixes, like so:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/qt.scm
@@ -634,6 +634,8 @@ (define-public qtbase
     (build-system cmake-build-system)
     (arguments
      (substitute-keyword-arguments (package-arguments qtbase-5)
+       ((#:disallowed-references _ #f)
+        (list python))
        ((#:configure-flags _ ''())
         `(let ((out (assoc-ref %outputs "out")))
            (list "-DQT_BUILD_TESTS=ON"
@@ -727,7 +729,8 @@ (define-public qtbase
             (add-after 'patch-source-shebangs 'do-not-capture-python
               (lambda _
                 (substitute* '("mkspecs/features/uikit/devices.py"
-                               "util/testrunner/qt-testrunner.py")
+                               "util/testrunner/qt-testrunner.py"
+                               "util/testrunner/sanitizer-testrunner.py")
                   (((which "python3"))
                    "/usr/bin/env python3"))))
             (replace 'configure
--8<---------------cut here---------------end--------------->8---

I'll push the fix to the telephony-team branch, since I had just removed
the qt-updates one.

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-22 19:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-22 18:18 bug#65457: qtbase refers to python 3 Maxim Cournoyer
2023-08-22 19:13 ` Maxim Cournoyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).