* bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash
@ 2014-07-21 4:37 Mark H Weaver
2014-07-21 16:12 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: Mark H Weaver @ 2014-07-21 4:37 UTC (permalink / raw)
To: 18068
'module-init-tools' (with our patch) assumes that LINUX_MODULE_DIRECTORY
ends with a trailing slash. However, 'udev-service' sets
LINUX_MODULE_DIRECTORY to "/run/booted-system/kernel/lib/modules".
One option would be to add a trailing slash:
--8<---------------cut here---------------start------------->8---
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -488,7 +488,7 @@ passed to @command{guix-daemon}."
;; Allow udev to find the modules.
(setenv "LINUX_MODULE_DIRECTORY"
- "/run/booted-system/kernel/lib/modules")
+ "/run/booted-system/kernel/lib/modules/")
(let ((pid (primitive-fork)))
(case pid
--8<---------------cut here---------------end--------------->8---
Another option would be to change module-init-tools-moduledir.patch to
cope with the lack of a trailing slash.
Thoughts?
Thanks,
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash
2014-07-21 4:37 bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash Mark H Weaver
@ 2014-07-21 16:12 ` Ludovic Courtès
2014-07-23 2:22 ` Mark H Weaver
0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2014-07-21 16:12 UTC (permalink / raw)
To: Mark H Weaver; +Cc: 18068
I think it would be best to fix the module-init-tools patch.
Could you look into it?
(Note that (1) udev uses kmod, not module-init-tools, and (2) it’s
possible to use ‘kmod load’ instead of ‘insmod’.)
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash
2014-07-21 16:12 ` Ludovic Courtès
@ 2014-07-23 2:22 ` Mark H Weaver
2014-07-23 17:10 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: Mark H Weaver @ 2014-07-23 2:22 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 18068
ludo@gnu.org (Ludovic Courtès) writes:
> I think it would be best to fix the module-init-tools patch.
> Could you look into it?
Okay.
> (Note that (1) udev uses kmod, not module-init-tools, and (2) it’s
> possible to use ‘kmod load’ instead of ‘insmod’.)
Hmm, yes, I would like to transition to kmod from module-init-tools, but
'kmod load' doesn't work for me, at least not within the standalone guix
system. 'kmod help' doesn't list 'load' as one of the commands either.
The only way I was able to get 'kmod' to work was to create a symlink
named 'modprobe' that points to it, and then running that.
I think we should consider creating those symlinks in our 'kmod'
package. What do you think?
Thanks!
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash
2014-07-23 2:22 ` Mark H Weaver
@ 2014-07-23 17:10 ` Ludovic Courtès
2014-07-23 19:53 ` Mark H Weaver
0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2014-07-23 17:10 UTC (permalink / raw)
To: Mark H Weaver; +Cc: 18068-done
Commits 906f704 and 4a8b4c2 address both issues. Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash
2014-07-23 17:10 ` Ludovic Courtès
@ 2014-07-23 19:53 ` Mark H Weaver
2014-07-23 20:28 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: Mark H Weaver @ 2014-07-23 19:53 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 18068
Hi Ludovic,
ludo@gnu.org (Ludovic Courtès) writes:
> Commits 906f704 and 4a8b4c2 address both issues. Thanks!
Alas, this seems to have broken the linux-libre builds on all platforms.
Thanks!
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash
2014-07-23 19:53 ` Mark H Weaver
@ 2014-07-23 20:28 ` Ludovic Courtès
0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2014-07-23 20:28 UTC (permalink / raw)
To: Mark H Weaver; +Cc: 18068
Mark H Weaver <mhw@netris.org> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>> Commits 906f704 and 4a8b4c2 address both issues. Thanks!
>
> Alas, this seems to have broken the linux-libre builds on all platforms.
I had forgotten one, it is fixed with 94b1342.
Thanks for the heads-up!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-23 20:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-21 4:37 bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash Mark H Weaver
2014-07-21 16:12 ` Ludovic Courtès
2014-07-23 2:22 ` Mark H Weaver
2014-07-23 17:10 ` Ludovic Courtès
2014-07-23 19:53 ` Mark H Weaver
2014-07-23 20:28 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).