From: "Ludovic Courtès" <ludo@gnu.org>
To: "Amar M. Singh" <nly@disroot.org>
Cc: 44104@debbugs.gnu.org
Subject: bug#44104: [patch] guix/scripts/publish: share signing key
Date: Wed, 21 Oct 2020 15:11:09 +0200 [thread overview]
Message-ID: <875z734tci.fsf@gnu.org> (raw)
In-Reply-To: <86imb4bn3z.fsf@disroot.org> (Amar M. Singh's message of "Wed, 21 Oct 2020 03:01:44 +0530")
Hi,
"Amar M. Singh" <nly@disroot.org> skribis:
>>From 554416649b7400d0bbe440016c6a6a7fed0d870a Mon Sep 17 00:00:00 2001
> From: Amar Singh <nly@disroot.org>
> Date: Wed, 21 Oct 2020 02:02:02 +0530
> Subject: [PATCH] guix publish: We provide signing key. Knock yourselves out!
>
> Best in industry.
>
> Signed-off-by: Amar Singh <nly@disroot.org>
> ---
> guix/scripts/publish.scm | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
Great idea! Some comments:
> +++ b/guix/scripts/publish.scm
> @@ -1,5 +1,6 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2015 David Thompson <davet@gnu.org>
> +;;; Copyright (C) 2020 by Amar M. Singh <nly@disroot.org>
> ;;; Copyright © 2015, 2016, 2017, 2018, 2019, 2020 Ludovic Courtès <ludo@gnu.org>
Please use the same format as the other lines.
> +(define (render-signing-key)
> + "Render signing key."
> + (let ((file "/etc/guix/signing-key.pub"))
> + (values `((content-type . (text/plain (charset . "UTF-8")))
> + (x-raw-file . ,file))
> + file)))
Use ‘%public-key-file’ (from (guix pki)) instead of ‘file’ here.
It would be great if you could add a test in ‘tests/publish.scm’ that
ensures GET /singing-key.pub returns 200 (you can use the
“/nix-cache-info” as a starting point and we can chat on IRC if you need
guidance.)
Bonus points if you can provide a commit log that follows our
conventions:
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
:-)
Could you send an updated patch?
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-10-21 13:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 20:04 bug#44104: guix publish should publish public key Amar M. Singh
2020-10-20 21:31 ` bug#44104: [patch] guix/scripts/publish: share signing key Amar M. Singh
2020-10-21 13:11 ` Ludovic Courtès [this message]
2020-10-22 7:48 ` bug#44104: [patch] guix publish: provide server's " Amar M. Singh
2020-10-26 22:57 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z734tci.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=44104@debbugs.gnu.org \
--cc=nly@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).