From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qFTgHaszkF89EgAA0tVLHw (envelope-from ) for ; Wed, 21 Oct 2020 13:12:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iEuuGaszkF/KCgAAB5/wlQ (envelope-from ) for ; Wed, 21 Oct 2020 13:12:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F196B9403EE for ; Wed, 21 Oct 2020 13:12:10 +0000 (UTC) Received: from localhost ([::1]:51926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVDuU-0007wO-0F for larch@yhetil.org; Wed, 21 Oct 2020 09:12:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVDuM-0007w1-OP for bug-guix@gnu.org; Wed, 21 Oct 2020 09:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36693) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVDuM-0002Hq-F6 for bug-guix@gnu.org; Wed, 21 Oct 2020 09:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kVDuM-00053w-Au for bug-guix@gnu.org; Wed, 21 Oct 2020 09:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44104: [patch] guix/scripts/publish: share signing key Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 21 Oct 2020 13:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44104 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: "Amar M. Singh" Received: via spool by 44104-submit@debbugs.gnu.org id=B44104.160328587819400 (code B ref 44104); Wed, 21 Oct 2020 13:12:02 +0000 Received: (at 44104) by debbugs.gnu.org; 21 Oct 2020 13:11:18 +0000 Received: from localhost ([127.0.0.1]:48238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVDte-00052p-Dd for submit@debbugs.gnu.org; Wed, 21 Oct 2020 09:11:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVDtc-00052Z-U7 for 44104@debbugs.gnu.org; Wed, 21 Oct 2020 09:11:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48564) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVDtX-0002Ec-Ar; Wed, 21 Oct 2020 09:11:11 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43438 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kVDtW-00041L-81; Wed, 21 Oct 2020 09:11:10 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <86lfg0br4s.fsf@disroot.org> <86imb4bn3z.fsf@disroot.org> Date: Wed, 21 Oct 2020 15:11:09 +0200 In-Reply-To: <86imb4bn3z.fsf@disroot.org> (Amar M. Singh's message of "Wed, 21 Oct 2020 03:01:44 +0530") Message-ID: <875z734tci.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44104@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: MHXZmdezDaJM Hi, "Amar M. Singh" skribis: >>>From 554416649b7400d0bbe440016c6a6a7fed0d870a Mon Sep 17 00:00:00 2001 > From: Amar Singh > Date: Wed, 21 Oct 2020 02:02:02 +0530 > Subject: [PATCH] guix publish: We provide signing key. Knock yourselves o= ut! > > Best in industry. > > Signed-off-by: Amar Singh > --- > guix/scripts/publish.scm | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) Great idea! Some comments: > +++ b/guix/scripts/publish.scm > @@ -1,5 +1,6 @@ > ;;; GNU Guix --- Functional package management for GNU > ;;; Copyright =C2=A9 2015 David Thompson > +;;; Copyright (C) 2020 by Amar M. Singh > ;;; Copyright =C2=A9 2015, 2016, 2017, 2018, 2019, 2020 Ludovic Court=C3= =A8s Please use the same format as the other lines. > +(define (render-signing-key) > + "Render signing key." > + (let ((file "/etc/guix/signing-key.pub")) > + (values `((content-type . (text/plain (charset . "UTF-8"))) > + (x-raw-file . ,file)) > + file))) Use =E2=80=98%public-key-file=E2=80=99 (from (guix pki)) instead of =E2=80= =98file=E2=80=99 here. It would be great if you could add a test in =E2=80=98tests/publish.scm=E2= =80=99 that ensures GET /singing-key.pub returns 200 (you can use the =E2=80=9C/nix-cache-info=E2=80=9D as a starting point and we can chat on IR= C if you need guidance.) Bonus points if you can provide a commit log that follows our conventions: https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html :-) Could you send an updated patch? Thanks, Ludo=E2=80=99.