unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#31757: 'guix system disk-image --format=iso9660' includes more than the OS closure
@ 2018-06-08 13:23 Ludovic Courtès
  2018-06-26 12:30 ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2018-06-08 13:23 UTC (permalink / raw)
  To: 31757

Hey hey!

Turns out ‘guix system disk-image --format=iso9660’ includes not sure
the closure of the given OS, but everything that’s in the build
environment’s store.  So typically, we end up with QEMU and all in
addition to the store’s closure.

This stems from the fact that ‘make-iso9660-image’ does:

--8<---------------cut here---------------start------------->8---
    (apply invoke
           `(,grub-mkrescue "-o" ,target
                            ,(string-append "boot/grub/grub.cfg=" config-file)
                            ,(string-append "gnu/store=" os-drv "/..")
                            "etc=/tmp/root/etc"
                            "var=/tmp/root/var"
                            "run=/tmp/root/run"
                            ;; /mnt is used as part of the installation
                            ;; process, as the mount point for the target
                            ;; file system, so create it.
                            "mnt=/tmp/root/mnt"
                            "--"
                            "-volid" ,(string-upcase volume-id)
                            ,@(if volume-uuid
                                  `("-volume_date" "uuid"
                                    ,(string-filter (lambda (value)
                                                      (not (char=? #\- value)))
                                                    (iso9660-uuid->string
                                                     volume-uuid)))
                                  `())))
--8<---------------cut here---------------end--------------->8---

The “gnu/store=…” argument means we’re adding the whole store to the ISO.

Ludo’.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#31757: 'guix system disk-image --format=iso9660' includes more than the OS closure
  2018-06-08 13:23 bug#31757: 'guix system disk-image --format=iso9660' includes more than the OS closure Ludovic Courtès
@ 2018-06-26 12:30 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2018-06-26 12:30 UTC (permalink / raw)
  To: 31757-done

ludo@gnu.org (Ludovic Courtès) skribis:

> Turns out ‘guix system disk-image --format=iso9660’ includes not sure
> the closure of the given OS, but everything that’s in the build
> environment’s store.  So typically, we end up with QEMU and all in
> addition to the store’s closure.

Fixed in 718d44cc9ff1a7e97b4e4ce028cc273c2e20cf93.

Ludo’.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-06-26 12:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-08 13:23 bug#31757: 'guix system disk-image --format=iso9660' includes more than the OS closure Ludovic Courtès
2018-06-26 12:30 ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).