* bug#19743: 'wrap-program' should preserve symbolic links
@ 2015-02-01 21:41 Ludovic Courtès
2015-02-16 14:27 ` bug#19743: Close Andreas Enge
[not found] ` <20150215164206.GA6486@debian>
0 siblings, 2 replies; 3+ messages in thread
From: Ludovic Courtès @ 2015-02-01 21:41 UTC (permalink / raw)
To: 19743
[-- Attachment #1: Type: text/plain, Size: 133 bytes --]
When ‘wrap-program’ is called on a symbolic link, it should preserve its
symboliclinkness instead of copying it.
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 477 bytes --]
diff --git a/guix/build/utils.scm b/guix/build/utils.scm
index 4407f9a..56f682c 100644
--- a/guix/build/utils.scm
+++ b/guix/build/utils.scm
@@ -837,7 +837,7 @@ the previous wrapper."
(if (zero? number)
(let ((prog-real (string-append (dirname prog) "/."
(basename prog) "-real")))
- (copy-file prog prog-real)
+ (rename-file prog prog-real)
prog-real)
(wrapper-file-name number)))
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#19743: Close
2015-02-01 21:41 bug#19743: 'wrap-program' should preserve symbolic links Ludovic Courtès
@ 2015-02-16 14:27 ` Andreas Enge
[not found] ` <20150215164206.GA6486@debian>
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Enge @ 2015-02-16 14:27 UTC (permalink / raw)
To: 19743-done
Applied in commit da466f7ff63e34aca271e603090f25ba471f009e.
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#19743: 'wrap-program' should preserve symbolic links
[not found] ` <20150215164206.GA6486@debian>
@ 2015-02-23 19:45 ` Ludovic Courtès
0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2015-02-23 19:45 UTC (permalink / raw)
To: Andreas Enge; +Cc: 19743
Andreas Enge <andreas@enge.fr> skribis:
> From cced64ffd33754434d732c552bdbb5c038891a8d Mon Sep 17 00:00:00 2001
> From: Andreas Enge <andreas@enge.fr>
> Date: Sun, 15 Feb 2015 17:40:17 +0100
> Subject: [PATCH] utils: Preserve symbolic links in 'wrap-program'.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * guix/build/utils.scm (wrap-program): Preserve symbolic links instead of
> copying the contents of the link.
^^
No extra space here please.
> Co-authored-by: Ludovic Courtès <ludo@gnu.org>
>
> Closes <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19743>.
Use “Fixes: ...” as in the other commits.
OK for ‘core-updates’.
Thank you!
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-23 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-01 21:41 bug#19743: 'wrap-program' should preserve symbolic links Ludovic Courtès
2015-02-16 14:27 ` bug#19743: Close Andreas Enge
[not found] ` <20150215164206.GA6486@debian>
2015-02-23 19:45 ` bug#19743: 'wrap-program' should preserve symbolic links Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).