bug#24168: Offloading builds does not honor --keep-failed

bug#24168: Offloading builds does not honor --keep-failed

[ng0]

This bug is to keep track of and not forget to add this feature to
build offloading:

When I offload builds to my build machine(s), I want to keep the results
of failed builds to investigate the reason for failure.

Currently this does not happen with offloading, we should fix this as
its a nice feature to have.
-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

bug#24168: Offloading builds does not honor --keep-failed

[ng0]

ng0 <ng0@we.make.ritual.n0.is> writes:

> This bug is to keep track of and not forget to add this feature to
> build offloading:
>
> When I offload builds to my build machine(s), I want to keep the results
> of failed builds to investigate the reason for failure.
>
> Currently this does not happen with offloading, we should fix this as
> its a nice feature to have.

Adding to this: offloading does not support `guix build --keep-going`
either.

-- 
♥Ⓐ  ng0
For non-prism friendly talk find me on http://www.psyced.org

bug#24168: Offloading builds does not honor --keep-failed

[ng0]

ng0 <ng0@we.make.ritual.n0.is> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> This bug is to keep track of and not forget to add this feature to
>> build offloading:
>>
>> When I offload builds to my build machine(s), I want to keep the results
>> of failed builds to investigate the reason for failure.
>>
>> Currently this does not happen with offloading, we should fix this as
>> its a nice feature to have.
>
> Adding to this: offloading does not support `guix build --keep-going`
> either.
>

Additionally with enabled offloading, guix pull has no option to build
on its own when the build machines are down.

Being able to pass something like
guix pull -- --no-build-hook
would be good.

-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org

bug#24168: Offloading builds does not honor --keep-failed

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

On Wed, Aug 24, 2016 at 10:04:01PM +0000, ng0 wrote:
> ng0 <ng0@we.make.ritual.n0.is> writes:
> 
> > ng0 <ng0@we.make.ritual.n0.is> writes:
> >

Offloading still does not honor --keep-failed, but with
b3673e9917217fc27c743092e58e4eb33d0fdd16 there is at least a warning
about it now.

> >> This bug is to keep track of and not forget to add this feature to
> >> build offloading:
> >>
> >> When I offload builds to my build machine(s), I want to keep the results
> >> of failed builds to investigate the reason for failure.
> >>
> >> Currently this does not happen with offloading, we should fix this as
> >> its a nice feature to have.
> >
> > Adding to this: offloading does not support `guix build --keep-going`
> > either.
> >
> 
> Additionally with enabled offloading, guix pull has no option to build
> on its own when the build machines are down.
> 
> Being able to pass something like
> guix pull -- --no-build-hook
> would be good.
> 

Not sure when it was added, but 'guix pull --no-build-hook' does work
(now).

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#24168: Offloading builds does not honor --keep-failed

[Ludovic Courtès]

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Wed, Aug 24, 2016 at 10:04:01PM +0000, ng0 wrote:
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>> 
>> > ng0 <ng0@we.make.ritual.n0.is> writes:
>> >
>
> Offloading still does not honor --keep-failed, but with
> b3673e9917217fc27c743092e58e4eb33d0fdd16 there is at least a warning
> about it now.

Actually no.  :-)  The warning is for when you have

  GUIX_DAEMON_SOCKET=guix://host.example.com

and not when you’re offloading.

I was thinking that we could turn off offloading when ‘-K’ is passed;
that’s usually what one expects no?

Thanks,
Ludo’.

bug#24168: Offloading builds does not honor --keep-failed

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> I was thinking that we could turn off offloading when ‘-K’ is passed;
> that’s usually what one expects no?

It's certainly my main use of '--no-build-hook'.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#24168: Offloading builds does not honor --keep-failed

[Marius Bakke]

This is a feature, not a bug; and the other points discussed have been
resolved.  Closing!