* bug#54691: [PATCH] gnu: fortune-mod: Remove off database. [not found] <20220716122126.26328-1-raingloom@riseup.net> @ 2022-07-16 13:32 ` Liliana Marie Prikler 2022-07-16 13:40 ` Csepp 0 siblings, 1 reply; 4+ messages in thread From: Liliana Marie Prikler @ 2022-07-16 13:32 UTC (permalink / raw) To: raingloom; +Cc: 54691, control merge 56599 54691 thanks Am Samstag, dem 16.07.2022 um 14:21 +0200 schrieb raingloom: > * gnu/packages/games.scm (fortune-mod): Delete off database after > install phase. > --- > gnu/packages/games.scm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > index 713f9339b2..cf10ebc9b6 100644 > --- a/gnu/packages/games.scm > +++ b/gnu/packages/games.scm > @@ -7721,7 +7721,10 @@ (define-public fortune-mod > (lambda _ > (with-directory-excursion #$output > (rename-file "games/fortune" "bin/fortune") > - (rmdir "games"))))))) > + (rmdir "games")))) > + (add-after 'install 'commit-censorship > + (lambda* (#:key outputs #:allow-other-keys) > + (delete-file-recursively (string-append Truly offensive files should be removed with a snippet rather than a funnily named phase. I'm not sure if this applies to all of off, but let it be said, that there's plenty of fortunes that'd violate the CoC in files not labeled as such. Some files could probably be salvaged if we only removed some quotes – for example limericks about numbers are probably fine, but other limericks aren't. Furthermore, we should also revise the list of fortunes not in off, men-women is just an alternate spelling of sexism. Cheers ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#54691: [PATCH] gnu: fortune-mod: Remove off database. 2022-07-16 13:32 ` bug#54691: [PATCH] gnu: fortune-mod: Remove off database Liliana Marie Prikler @ 2022-07-16 13:40 ` Csepp 2022-07-16 13:46 ` Liliana Marie Prikler 0 siblings, 1 reply; 4+ messages in thread From: Csepp @ 2022-07-16 13:40 UTC (permalink / raw) To: Liliana Marie Prikler; +Cc: 54691, control, raingloom Liliana Marie Prikler <liliana.prikler@student.tugraz.at> writes: > merge 56599 54691 > thanks > > Am Samstag, dem 16.07.2022 um 14:21 +0200 schrieb raingloom: >> * gnu/packages/games.scm (fortune-mod): Delete off database after >> install phase. >> --- >> gnu/packages/games.scm | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm >> index 713f9339b2..cf10ebc9b6 100644 >> --- a/gnu/packages/games.scm >> +++ b/gnu/packages/games.scm >> @@ -7721,7 +7721,10 @@ (define-public fortune-mod >> (lambda _ >> (with-directory-excursion #$output >> (rename-file "games/fortune" "bin/fortune") >> - (rmdir "games"))))))) >> + (rmdir "games")))) >> + (add-after 'install 'commit-censorship >> + (lambda* (#:key outputs #:allow-other-keys) >> + (delete-file-recursively (string-append > Truly offensive files should be removed with a snippet rather than a > funnily named phase. I'm not sure if this applies to all of off, but > let it be said, that there's plenty of fortunes that'd violate the CoC > in files not labeled as such. Some files could probably be salvaged if > we only removed some quotes – for example limericks about numbers are > probably fine, but other limericks aren't. Furthermore, we should also > revise the list of fortunes not in off, men-women is just an alternate > spelling of sexism. > > Cheers That's probably better done as a fork of upstream. If no one wants to do that, I wouldn't miss the package if it got yeeted. :shrug: ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#54691: [PATCH] gnu: fortune-mod: Remove off database. 2022-07-16 13:40 ` Csepp @ 2022-07-16 13:46 ` Liliana Marie Prikler 2022-07-17 13:05 ` Csepp 0 siblings, 1 reply; 4+ messages in thread From: Liliana Marie Prikler @ 2022-07-16 13:46 UTC (permalink / raw) To: Csepp; +Cc: 54691, control Am Samstag, dem 16.07.2022 um 15:40 +0200 schrieb Csepp: > > Liliana Marie Prikler <liliana.prikler@student.tugraz.at> writes: > > > merge 56599 54691 > > thanks > > > > Am Samstag, dem 16.07.2022 um 14:21 +0200 schrieb raingloom: > > > * gnu/packages/games.scm (fortune-mod): Delete off database after > > > install phase. > > > --- > > > gnu/packages/games.scm | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > > > index 713f9339b2..cf10ebc9b6 100644 > > > --- a/gnu/packages/games.scm > > > +++ b/gnu/packages/games.scm > > > @@ -7721,7 +7721,10 @@ (define-public fortune-mod > > > (lambda _ > > > (with-directory-excursion #$output > > > (rename-file "games/fortune" "bin/fortune") > > > - (rmdir "games"))))))) > > > + (rmdir "games")))) > > > + (add-after 'install 'commit-censorship > > > + (lambda* (#:key outputs #:allow-other-keys) > > > + (delete-file-recursively (string-append > > Truly offensive files should be removed with a snippet rather than > > a funnily named phase. I'm not sure if this applies to all of off, > > but let it be said, that there's plenty of fortunes that'd violate > > the CoC in files not labeled as such. Some files could probably be > > salvaged if we only removed some quotes – for example limericks > > about numbers are probably fine, but other limericks aren't. > > Furthermore, we should also revise the list of fortunes not in off, > > men-women is just an alternate spelling of sexism. > > > > Cheers > > That's probably better done as a fork of upstream. If no one wants to > do that, I wouldn't miss the package if it got yeeted. :shrug: I'm not necessarily asking you to go over joke for joke; that would need to be a collective decision of Guix folk anyway. Right now I just want to (1) make that a snippet and (2) also take a critical look at the files not labeled "offensive". Cheers ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#54691: [PATCH] gnu: fortune-mod: Remove off database. 2022-07-16 13:46 ` Liliana Marie Prikler @ 2022-07-17 13:05 ` Csepp 0 siblings, 0 replies; 4+ messages in thread From: Csepp @ 2022-07-17 13:05 UTC (permalink / raw) To: Liliana Marie Prikler; +Cc: 54691, control, Csepp Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > Am Samstag, dem 16.07.2022 um 15:40 +0200 schrieb Csepp: >> >> Liliana Marie Prikler <liliana.prikler@student.tugraz.at> writes: >> >> > merge 56599 54691 >> > thanks >> > >> > Am Samstag, dem 16.07.2022 um 14:21 +0200 schrieb raingloom: >> > > * gnu/packages/games.scm (fortune-mod): Delete off database after >> > > install phase. >> > > --- >> > > gnu/packages/games.scm | 5 ++++- >> > > 1 file changed, 4 insertions(+), 1 deletion(-) >> > > >> > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm >> > > index 713f9339b2..cf10ebc9b6 100644 >> > > --- a/gnu/packages/games.scm >> > > +++ b/gnu/packages/games.scm >> > > @@ -7721,7 +7721,10 @@ (define-public fortune-mod >> > > (lambda _ >> > > (with-directory-excursion #$output >> > > (rename-file "games/fortune" "bin/fortune") >> > > - (rmdir "games"))))))) >> > > + (rmdir "games")))) >> > > + (add-after 'install 'commit-censorship >> > > + (lambda* (#:key outputs #:allow-other-keys) >> > > + (delete-file-recursively (string-append >> > Truly offensive files should be removed with a snippet rather than >> > a funnily named phase. I'm not sure if this applies to all of off, >> > but let it be said, that there's plenty of fortunes that'd violate >> > the CoC in files not labeled as such. Some files could probably be >> > salvaged if we only removed some quotes – for example limericks >> > about numbers are probably fine, but other limericks aren't. >> > Furthermore, we should also revise the list of fortunes not in off, >> > men-women is just an alternate spelling of sexism. >> > >> > Cheers >> >> That's probably better done as a fork of upstream. If no one wants to >> do that, I wouldn't miss the package if it got yeeted. :shrug: > I'm not necessarily asking you to go over joke for joke; that would > need to be a collective decision of Guix folk anyway. Right now I just > want to (1) make that a snippet and (2) also take a critical look at > the files not labeled "offensive". > > Cheers Doing it before the install phase requires also patching the build scripts. There are a bunch of other bugs calling me sadly, so I'm not super keen on putting more energy into this one. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-17 13:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220716122126.26328-1-raingloom@riseup.net>
2022-07-16 13:32 ` bug#54691: [PATCH] gnu: fortune-mod: Remove off database Liliana Marie Prikler
2022-07-16 13:40 ` Csepp
2022-07-16 13:46 ` Liliana Marie Prikler
2022-07-17 13:05 ` Csepp
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).